Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language selector #47

Merged
merged 4 commits into from
Aug 5, 2019
Merged

Language selector #47

merged 4 commits into from
Aug 5, 2019

Conversation

santakadev
Copy link
Contributor

@santakadev santakadev commented Jun 23, 2019 •
edited

@santakadev santakadev added the feature New feature or request label Jun 23, 2019
@santakadev santakadev added this to the 1.1 milestone Jun 23, 2019
@santakadev santakadev self-assigned this Jun 23, 2019
@santakadev santakadev added this to In progress in P2P Editor via automation Jun 23, 2019
@rgomezcasas
Copy link
Member

For some reason it's failing... :/
image

@santakadev
Copy link
Contributor Author

For some reason it's failing... :/
image

Fixed! There was an issue with HTTPS.

P2P Editor automation moved this from In progress to Reviewer approved Aug 5, 2019
JavierCane
JavierCane approved these changes Aug 5, 2019
View reviewed changes
Copy link
Member

@JavierCane JavierCane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@JavierCane JavierCane merged commit 8c620a9 into master Aug 5, 2019
P2P Editor automation moved this from Reviewer approved to Done Aug 5, 2019
@JavierCane JavierCane deleted the language-selector branch August 5, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JavierCane JavierCane JavierCane approved these changes

Assignees

@santakadev santakadev

Labels
feature New feature or request
Projects
P2P Editor
  
Done
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@santakadev @rgomezcasas @JavierCane