Refactor PastIteration mounting process #379

andrerpbts · 2018-09-08T02:39:45Z

It was full of N+1 queries, and letting the things very slow

andrerpbts · 2018-09-08T19:14:28Z

@akitaonrails @talyssonoc @adbatista There's a Review App up to tests.

Please note, since it's rebased with master, it is running with all those dependencies updated. Lets try to merge it on monday, please.

talyssonoc · 2018-09-10T12:39:16Z

app/models/iterations/project_iterations.rb

+
+    def stories_from(start_at, end_at)
+      stories.select do |story|
+        story.accepted_at >= start_at && story.accepted_at <= end_at


Isn't it better to do these conditionals with a query instead of directly in Ruby side?

Dunno, I moved from a query because it was doing a lot of queries to get all this...

Only if we have a query to bring grouped those stories by start/end_at...

talyssonoc · 2018-09-10T12:40:45Z

app/models/iterations/project_iterations.rb

    def length
      (days_since_project_start / iteration_length_in_days).floor
    end

    def iteration_length_in_days
-      @project.iteration_length * 7
+      project.iteration_length * 7


Since we're already here, what do you think about extracting the 7 to a DAYS_IN_A_WEEK constant?

talyssonoc · 2018-09-10T12:41:28Z

app/operations/iteration_operations.rb

+        project
+          .stories
+          .with_dependencies
+          .where('accepted_at >= ? AND accepted_at <= ?', start_date, end_date)


Isn't this the same thing as https://github.com/Codeminer42/cm42-central/pull/379/files#diff-0648f597f84a74e685e5eabc0855e13cR31 ?

Almost, but for just one past_iteration...

@rodrigovirgilio ☝️

talyssonoc · 2018-09-10T12:42:15Z

app/operations/story_operations.rb

+          .with_dependencies
+          .where("state != 'accepted' OR accepted_at >= ?", current_iteration_start)
+          .order('updated_at DESC')
+          .limit(ENV['STORIES_CEILING'].presence&.to_i)


What do you think about extracting the ENV['STORIES_CEILING'].presence&.to_i to a method?

I want to understand why this ceiling is there?

Active stories need to be limited?

I'm removing this. We are lazy loading done stories nowadays.

As spoke offline, we won't need this limit anymore.

talyssonoc · 2018-09-10T12:45:22Z

app/models/iterations/project_iterations.rb

+          .stories
+          .with_dependencies
+          .where(state: 'accepted')
+          .where.not(accepted_at: nil)


I think that chaining where calls will create an AND instead of an OR, right? If so, does it make sense to have stories that are accepted but have no accepted_at value? 🤔

Yeah, makes sense, but I would keep it to prevent any possible inconsistence. It reflects exactly the kind of stories I'm expecting in the filter method above.

adbatista · 2018-09-10T15:53:39Z

app/models/iterations/past_iteration.rb

-      @stories ||= @project.stories.where(
-        'accepted_at >= ? AND accepted_at <= ?', @start_date, @end_date
-      )
+      @points ||= stories.to_a.map(&:estimate).compact.sum


why not stories.sum(:estimate) ?

Not every story has value in estimate, so I'm doing a map, compacting to remove nil values, and summing after.

I can change if you have a better approach...

just for clarification:

to_a here is only to always ensure we are doing it in an array, never into database. I'm avoiding queries here...

It was full of N+1 queries, and getting the things very slow

andrerpbts · 2018-09-12T13:19:59Z

app/models/iterations/project_iterations.rb

-                          end_date: end_date,
-                          project: @project,
-                          iteration_number: iteration_number + 1)
+        start_at = start_date(iteration_number)


@rodrigovirgilio apply beginning_of_day and end_of_day in those methods

Applied a39d2c9

akitaonrails temporarily deployed to cm-fulcrum-pr-379 September 8, 2018 02:44 Inactive

andrerpbts force-pushed the fix/past_iterations branch from 2f2a0a6 to fa9f799 Compare September 8, 2018 15:05

andrerpbts had a problem deploying to cm-fulcrum-pr-379 September 8, 2018 15:05 Failure

andrerpbts force-pushed the fix/past_iterations branch from fa9f799 to 58fe723 Compare September 8, 2018 15:07

andrerpbts temporarily deployed to cm-fulcrum-pr-379 September 8, 2018 15:07 Inactive

andrerpbts requested review from adbatista, talyssonoc and akitaonrails September 8, 2018 15:08

andrerpbts added the WIP label Sep 8, 2018

andrerpbts changed the title ~~Refactor PastIteration mounting process~~ [WIP] Refactor PastIteration mounting process Sep 8, 2018

andrerpbts mentioned this pull request Sep 8, 2018

Importing stories in a new project after an export from an existing project doesn't work #317

Closed

andrerpbts force-pushed the fix/past_iterations branch from 58fe723 to f6c8dbe Compare September 8, 2018 18:03

andrerpbts temporarily deployed to cm-fulcrum-pr-379 September 8, 2018 18:03 Inactive

andrerpbts changed the title ~~[WIP] Refactor PastIteration mounting process~~ Refactor PastIteration mounting process Sep 8, 2018

andrerpbts removed the WIP label Sep 8, 2018

andrerpbts force-pushed the fix/past_iterations branch from f6c8dbe to 35727a0 Compare September 8, 2018 18:11

andrerpbts had a problem deploying to cm-fulcrum-pr-379 September 8, 2018 18:12 Failure

andrerpbts force-pushed the fix/past_iterations branch from 35727a0 to 094dee0 Compare September 8, 2018 18:13

andrerpbts had a problem deploying to cm-fulcrum-pr-379 September 8, 2018 18:13 Failure

andrerpbts force-pushed the fix/past_iterations branch from 094dee0 to b624717 Compare September 8, 2018 19:11

andrerpbts had a problem deploying to cm-fulcrum-pr-379 September 8, 2018 19:11 Failure

andrerpbts force-pushed the fix/past_iterations branch from b624717 to 8b38fbb Compare September 8, 2018 19:29

andrerpbts had a problem deploying to cm-fulcrum-pr-379 September 8, 2018 19:29 Failure

akitaonrails temporarily deployed to cm-fulcrum-pr-379 September 8, 2018 20:33 Inactive

talyssonoc reviewed Sep 10, 2018

View reviewed changes

andrerpbts temporarily deployed to cm-fulcrum-pr-379 September 10, 2018 13:05 Inactive

adbatista reviewed Sep 10, 2018

View reviewed changes

andrerpbts added 2 commits September 10, 2018 17:17

Refactor PastIteration mounting process

cb02254

It was full of N+1 queries, and getting the things very slow

Remove ceiling from active stories on project boards

ec30e09

andrerpbts force-pushed the fix/past_iterations branch from ef27aa5 to ec30e09 Compare September 10, 2018 20:17

andrerpbts temporarily deployed to cm-fulcrum-pr-379 September 10, 2018 20:18 Inactive

andrerpbts commented Sep 12, 2018

View reviewed changes

rodrigovirgilio temporarily deployed to cm-fulcrum-pr-379 September 12, 2018 13:56 Inactive

List all stories with datetime

cf3b208

andrerpbts force-pushed the fix/past_iterations branch from a39d2c9 to cf3b208 Compare September 14, 2018 13:14

andrerpbts deployed to cm-fulcrum-pr-379 September 14, 2018 13:14 View deployment

talyssonoc merged commit 25dad53 into master Sep 14, 2018

talyssonoc deleted the fix/past_iterations branch September 14, 2018 13:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor PastIteration mounting process #379

Refactor PastIteration mounting process #379

andrerpbts commented Sep 8, 2018

andrerpbts commented Sep 8, 2018

talyssonoc Sep 10, 2018

andrerpbts Sep 10, 2018

talyssonoc Sep 10, 2018

talyssonoc Sep 10, 2018

andrerpbts Sep 10, 2018

talyssonoc Sep 10, 2018

andrerpbts Sep 10, 2018

andrerpbts Sep 12, 2018

talyssonoc Sep 10, 2018

andrerpbts Sep 10, 2018

andrerpbts Sep 10, 2018

talyssonoc Sep 10, 2018

talyssonoc Sep 10, 2018

andrerpbts Sep 10, 2018

adbatista Sep 10, 2018

andrerpbts Sep 10, 2018

andrerpbts Sep 10, 2018

andrerpbts Sep 12, 2018

rodrigovirgilio Sep 12, 2018

Refactor PastIteration mounting process #379

Refactor PastIteration mounting process #379

Conversation

andrerpbts commented Sep 8, 2018

andrerpbts commented Sep 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment