New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null/undefined lyrics which cause exporter to fail #1026

Merged

Danielku15 merged 2 commits into develop from feature/null-lyrics

Nov 1, 2022

Member

Danielku15 commented Nov 1, 2022

Issues

Fixes #1025

Proposed changes

Ensure lyrics array is initialized with non-null values.

Checklist

I consent that this change becomes part of alphaTab under it's current or any future open source license
Changes are implemented
Existing builds tests pass
New tests were added

Further details

This is a breaking change
This change will require update of the documentation/website


          Fix null/undefined lyrics which cause exporter to fail

4a323b2

Danielku15 self-assigned this


          Ensure empty-string is falsy

3ac1556

Danielku15 force-pushed the feature/null-lyrics branch from 30ca13f to 3ac1556 Compare

November 1, 2022 13:26

Danielku15 merged commit ec568f1 into develop

Danielku15 deleted the feature/null-lyrics branch

November 1, 2022 13:35

ChiHoc pushed a commit to ChiHoc/alphaTab that referenced this pull request


          Fix null/undefined lyrics which cause exporter to fail (CoderLine#1026)

910d5b7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment