Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlphaTex Error improvements. Line/col numbers. #1059

Merged
merged 5 commits into from
Jan 14, 2023

Conversation

jonaro00
Copy link
Contributor

@jonaro00 jonaro00 commented Nov 27, 2022

Issues

  • Implements Add line and column number to AlphaTab errors #1044
  • Adds more details and logic to display better error messages overall:
    • Add a specific error for when a string is opened but never closed before EOF.
    • Only show incorrect values of _syData when it makes sense.
    • lastValidSpot makes sure the error message points out where the incorrect syntax started instead of where the importer discovered the error.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@jonaro00
Copy link
Contributor Author

All 3 builds passing now :)

@Danielku15 Danielku15 merged commit 9bc9c57 into CoderLine:develop Jan 14, 2023
@Danielku15
Copy link
Member

Thanks for the addition 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants