Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize TS generator, remove trailing whitespace from generated #1061

Merged
merged 6 commits into from
Jan 14, 2023

Conversation

jonaro00
Copy link
Contributor

@jonaro00 jonaro00 commented Nov 28, 2022

Proposed changes

  • I noticed that the TypeScript emitters (Clone, Serialize) do not care about the passed Diagnostics. The diagnostics take the most runtime. Therefore, I skip generating the diagnostics for those builds, which led to ~4.5s faster builds 馃槃. Since pretty much all other npm scripts in turn run the generate-typescript script, their build times also benefit from this speedup.
  • General code improvements in files related to the above.
  • Remove trailing whitespaces from the generated files.
  • Minor test case logging fixes.
  • Remove deprecated fields in .vscode launch configurations. Set default line ending to not save files as CRLF and mess with git.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

Copy link
Member

@Danielku15 Danielku15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. added some comments on how to adjust maybe some things differently.

src.compiler/typescript/EmitterBase.ts Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
src.compiler/typescript/EmitterBase.ts Show resolved Hide resolved
src/importer/ScoreLoader.ts Outdated Show resolved Hide resolved
test/audio/MidiFileGenerator.test.ts Outdated Show resolved Hide resolved
@Danielku15 Danielku15 merged commit bf8098f into CoderLine:develop Jan 14, 2023
@Danielku15
Copy link
Member

Thanks for the cleanup and optimizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants