Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for chordcollection without diagrams #1211

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1206

Proposed changes

Handle correctly the ChordCollection items which have no diagram element.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jul 3, 2023
@Danielku15 Danielku15 merged commit 3aef5a8 into develop Jul 6, 2023
4 checks passed
@Danielku15 Danielku15 deleted the feature/chords-without-diagram branch July 6, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load GPX files resulting in an error - bug report/ semi pull request
1 participant