Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Tick Lookup mechanism for cursor placement and highlighting. #1328

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1281

Proposed changes

This PR reworks largely how the MidiTickLookup works internally.

  • We slice now differently the masterbars into sections where one or multiple beats are played.
  • Within this new slices we then try to lookup based on a given tick and hint the positions.

For the sake of stability I didn't attempt any code level optimizations but kept the code rather readable.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Dec 27, 2023
@Danielku15 Danielku15 merged commit b079e29 into develop Dec 27, 2023
4 checks passed
@Danielku15 Danielku15 deleted the feature/rework-tick-lookup branch December 27, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When enableAnimatedBeatCursor=false, some section pointers may skip some notes
1 participant