Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty bars and pre-beat grace notes on new lookup logic #1347

Merged
merged 4 commits into from
Jan 21, 2024

Conversation

Danielku15
Copy link
Member

Issues

Fixes #1339

Proposed changes

Fixes the two scenarios described in the bug report:

  • We need to accept the beat of empty voices in the lookup to have the cursor considered.
  • We need to ensure we add pre-beat grace notes also to the previous bar lookup if possible
  • We need to ensure we take the original beat playback start for the visibility check, not the slice start.

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@Danielku15 Danielku15 self-assigned this Jan 21, 2024
@Danielku15 Danielku15 changed the title Feature/fix empty bar cursors Handle empty bars and pre-beat grace notes on new lookup logic Jan 21, 2024
@Danielku15 Danielku15 merged commit af75ecb into develop Jan 21, 2024
4 checks passed
@Danielku15 Danielku15 deleted the feature/fix-empty-bar-cursors branch January 21, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After upgrading to Commits #1334, it was found that when there is an empty bar, the cursor does not appear.
1 participant