Fixed mouse coords for big terminals (>=96 columns) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For columns >=96 mouse event data has bytes which cannot be correctly converted to utf8 string. Result string will have utf8 replacement character with charcode 65533 and all columns >= 96 will be incorrectly counted as 65501 Use readUInt8 directly on buffer to get correct column. replacement character for nonexistent UTF8 symbol
|
Sorry for taking a while to notice this. In the standard mouse reporting mode, coordinates are encoded as bytes. But this enables 1005 which encodes the coordinates as UTF-8. So if it's not working it's because your terminal doesn't support that. I'll rework this to use standard mouse reporting as well as 1006 and 1015 both of which write out the numbers in ASCII (and possibly still 1005) which should fix this. |
|
I pushed code to the dev branch which should fix this. I'm not entirely sure it's backwards compatible and I don't have any projects that use this to test it with, so could you try it and tell me if it works? |
|
It works! Thank you |
|
Great, published as v0.2.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For columns >=96 mouse event data has bytes which
cannot be correctly converted to utf8 string.
Result string will have utf8 replacement character
with charcode 65533 and all columns >= 96 will be
incorrectly counted as 65501
Use readUInt8 directly on buffer to get correct
column.
replacement character for nonexistent UTF8 symbol