Update from upstream repo kwsch/PKHeX #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwsch
force-pushed
the
master
branch
2 times, most recently
from
e13acf3
to
6bed33f
Compare
kwsch
force-pushed
the
master
branch
3 times, most recently
from
0c4f92a
to
9ef9355
Compare
kwsch
force-pushed
the
master
branch
2 times, most recently
from
a730ac5
to
6e9f230
Compare
kwsch
force-pushed
the
master
branch
2 times, most recently
from
bfccdae
to
fbb9e0b
Compare
kwsch
force-pushed
the
master
branch
2 times, most recently
from
c460f5b
to
ecee948
Compare
kwsch
force-pushed
the
master
branch
2 times, most recently
from
fcadbda
to
2bbd767
Compare
kwsch
force-pushed
the
master
branch
3 times, most recently
from
81c04d8
to
5d5d913
Compare
Closes #4300
Useful for save files with misplaced data (you really have to be using the program weirdly to get these flagged). Stuff like Eggs deposited in Daycare, non-fuseable species in the Fused slots, etc. Allow HaX to view any slot, & Delete if Set is allowed
StringBuilder.Append has some fancy interpolation handling in the latest NET8 so it's more clean than multiple append calls.
Needed to catch the EncounterStatic9 gifts (like Starter). Update es9->pk9 to use the property instead of duplicating that logic
PK5-PKMEditor no longer sets Hidden Ability flag for Rotom under HaX -- only set if unique hidden ability. Differentiate move source tagging for HOME, DexNav, and GB-Evolution fix some comma spacing
Co-authored-by: Professor Dirty <103500840+wubinwww@users.noreply.github.com>
* Fixed some SecretBase3 issues * Allow settings SpriteItems, use ushort for TID16
Prior implementation only accounted for moves with the description: "This move can't be used. It's recommended that this move is forgotten. Once forgotten, this move can't be remembered." New implementation now checks for the CanUseMove flag, as is done with BDSP/LA/SV. This catches some oddities, like Kinesis becoming usable in Ver. 1.2.0 (Isle of Armor, Kadabra/Alakazam), as well as some signature moves for unavailable Pokémon, like Judgment and Seed Flare.
`IsSlotX` is a little ambiguous; `IsBoxSlotX` much better.
skips allocating that big byte[][] entirely No more static byte[][] references in PKHeX.Core !
SWSH format SV origin mon would report Gen9 but skipped the tracker check, no more.
Already have a reference to it, no need to re-pivot off version. Remove old method for checking if a Daycare exists; not all daycares give eggs, and not all egg-producing games have daycares.
Importing had a bug where it would retain the metadata when setting to save file, rather than trimming down to the gift. Split them into separate classes like gen6+ Remove erroneous WB7 size; 0x108 is only valid for a subsection, and won't work with the class since it needs to pull from the localization data. Nobody should be affected by that change.
Uninitialized sectors are now no longer updated for checksums Checksums will be updated if not uninitialized (replacing battle video) Not that the game really checks the checksum (lol)
Stupid. Move ash greninja check up with the CanHaveAnyLanguage as it's rectified in Gen8+.
Fix dexnav move being allowed when relearn cleared and not learnable in dest game (duskull destiny bond gen9) Move farfetch'd check to top of not-nicknamed, add deferral for GO match
Allow external consumers to specify AES/MD5 implementation HOME: Replace direct usage of transforms with built-in wrapper methods for easier API replacement. BDSP: Replace incremental hash with one-liner for easier API replacement. Handle dirtying manually.
Update wc9 pkl update dependencies (qrcoder got some perf improvements) deduplicate HOME tracker message in SV by consolidating the methods
Need to not include it when cloning saves into the sav constructor, need to mirror it in metadata instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The remote
kwsch/PKHeXhas some new changes that aren't in this fork.So, here they are, ready to be merged! 🎉
If this pull request can be merged without conflict, you can publish your software
with these new changes. Otherwise, if you have merge conflicts, this
is the place to fix them.
Have fun! 👋
From,
🏊 Your Neighborly Backstroke Bot
PS. Hey, there's a new version of Backstroke available. If you'd like to configure repo-to-repo syncing or sync to all forks, check it out here.