Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show upcoming events in order #43

Merged
merged 1 commit into from
Nov 17, 2016
Merged

Show upcoming events in order #43

merged 1 commit into from
Nov 17, 2016

Conversation

mirhagk
Copy link
Contributor

@mirhagk mirhagk commented Nov 17, 2016

Right now the events are showing as the newest one first, which is weird for upcoming events, where you'd expect the first one to be the next event, followed by the one after that.

If there isn't some diligence in creating new event posts, this might have the last event show up as the first one, followed by the next event, but I personally think that's better than someone seeing the first one, thinking that was the next one and then missing an event!

Also I'm a horrible open source citizen because I haven't actually run this code to verify the change, I'm doing this through the github online editor like the terrible person I am. I will try and remember to test this until I get home, but merge and push to prod at your own risk until then :P

Right now the events are showing as the newest one first, which is weird for upcoming events, where you'd expect the first one to be the next event, followed by the one after that.

If there isn't some diligence in creating new event posts, this might have the last event show up as the first one, followed by the next event, but I personally think that's better than someone seeing the first one, thinking that was the next one and then missing an event!



Also I'm a horrible open source citizen because I haven't actually run this code to verify the change, I'm doing this through the github online editor like the terrible person I am. I will try and remember to test this until I get home, but merge and push to prod at your own risk until then :P
@rprouse
Copy link
Member

rprouse commented Nov 17, 2016

I pulled the branch and tested. Good idea, thanks.

Now if only you could tell us how to only show future events we could stop manually updating the limit 😄

@rprouse rprouse merged commit c4688ac into Codercamp:master Nov 17, 2016
@mirhagk
Copy link
Contributor Author

mirhagk commented Nov 17, 2016

I'll be honest, I've never used jekyll before. I'll give it a shot when I get home though, it might be time for me to convert my blog to something standard rather than building my own (also I need to get out of the .net world every once in a while).

@rprouse
Copy link
Member

rprouse commented Nov 17, 2016

@mirhagk I set Jekyll up on a clean computer this morning following the directions in the Readme. I ran into problems with Ruby Gem not recognizing the SSL certs. Ping me if you run into the same problem and I will walk you through the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants