-
Notifications
You must be signed in to change notification settings - Fork 271
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stop abusing private APIs for "Inspect Element" menu item
When WebKit2 first announced, there was no way for an app to take an NSMenu, modify it, and return the result when a context menu is presented. WebKit1 had a delegate method for that named: -webView:contextMenuItemsForElement:defaultMenuItems: WebKit2 added this delegate method, in private, but it was not available until the next update of macOS. 'Til then, we had to fake "Inspect Element" because we did not have access to the default implementation that is available through the delegate method. Apple now flags the function names that were used to do that. This will break "Inspect Element" on one version of macOS. Which one I don't even recall. But it is worth it to make the review process smoother.
- Loading branch information
Showing
4 changed files
with
29 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters