Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whenever gem #4

Merged
merged 4 commits into from
Jan 7, 2019
Merged

Add whenever gem #4

merged 4 commits into from
Jan 7, 2019

Conversation

aitorlb
Copy link
Contributor

@aitorlb aitorlb commented Dec 28, 2018

Add whenever gem

I basically copied what was done here:
https://gitlab.coditdev.net/decidim/decidim-codit-demo-app/commit/e58a2e63c471f616f4c05065cb56b7619cd72577

Although in here the application.rb file isn't modified:
CodiTramuntana/decidim-barcelona_energia-app@dd755ae

Copy link
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Are you going to add the tests you've found that can be performed against Whenever schedules?

@tramuntanal
Copy link
Contributor

@MarcReniu @isaacmg410, @aitorlb have probably found a bug because the active_job backend isn't configured to delayed_job in barcelona energia and probably some other installation.
Can you check please?

@aitorlb
Copy link
Contributor Author

aitorlb commented Dec 28, 2018

@tramuntanal I added the whenever-test gem and a spec, but dont know if it's that much help.
Just so you know, the schedule.jobs[:rake] used in the test returns the following:

[{:task=>"decidim:metrics:all", :every=>[1 day, {:at=>"2:00 am"}], :command=>"cd :path && :environment_variable=:environment :bundle_command rake :task --silent :output"}]

@MarcReniu
Copy link
Contributor

Why adding whenever-test gem and a spec for rake tasks? I mean, metrics rake task has been already tested in decidim.

@aitorlb
Copy link
Contributor Author

aitorlb commented Jan 7, 2019

You're right @MarcReniu , that's why I said that I didnt know if it was of much help...
Should I revert back to the initial commit @tramuntanal ?

Copy link
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@tramuntanal tramuntanal merged commit 34ac21c into master Jan 7, 2019
@aitorlb aitorlb deleted the Add-whenever-gem branch May 8, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants