Validate accepted emendation and test #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustibr
suggested changes
Nov 14, 2018
|
|
||
|
|
||
| let(:title) { "Loura Hansen II 1" } | ||
| let(:body) {"Dlksdjfklesjfklew lkdjflksdjflk sdlkfjsdlkfjskdjf lskdfj skjflk sjflksdjf lksjflksdjflks jflksd jlkdsjlckjksd"} |
There was a problem hiding this comment.
| @@ -13,7 +13,7 @@ class ReviewForm < Decidim::Amendable::Form | |||
| attribute :body, String | |||
| attribute :user_group_id, Integer | |||
|
|
|||
| validates :id, :amendable_gid, :emendation_gid, presence: true | |||
| validates :id, :amendable_gid, :title, :body, :emendation_gid, presence: true | |||
There was a problem hiding this comment.
amendable_fields (in this case :title and :body) should be dynamic as amendable is configurable.
… render Ammend Button
…ncement, emendation_actions ...
fix docs
* Fix proposals/emendations state * Test ProposalMCell proposal/emendation state * Fix rubocop offences (forgot) * Refactor amend proposal system spec * Start fixing admin dashboard * Fix admin dashboard * Start fixing amendment form validations * Refactor amendment form validations Basic functionality working with redirect_to amendable_gid * Refactor amendment form validation redirect_to * Feature/amendments proposals on proposals withdraw (#18) * Fix emendation withdraw * Refactor change_proposal_state_to_withdrawn * Fix proposals_show withdrawn translation missing * Fix states of proposals * Button Answer disabled if amendment * Refactor withdraw to work with "See all withdrawn proposals" * Check for amendments even if user is not logged in * Amend Proposal system test * Fix error when merging cristian/aitor branches * Check for amendments even if user is not logged in - fixed * Fix rubocop offences * Fix mistake when refactoring emendation withdraw Forgot to change withdraw_proposal.rb back to its original state. * Add withdraw amendment test * Fix admin dashboard * Add red color to withdrawn state in admin manager * Change proposal_state to resource_state * Resolve conversations * Feature/amendments proposals on proposals unable button (#19) * Unable "Answer" button when the proposal is an emendation * Fixed offenses with Rubocop * fixed translate
… render Ammend Button
… render Ammend Button
…ncement, emendation_actions ...
… render Ammend Button
…ncement, emendation_actions ...
marc-va
force-pushed
the
feature/amendments-proposals-on-proposals-accept
branch
from
8c3cb76
to
3e11a8c
Compare
…thub.com:CodiTramuntana/decidim into feature/amendments-proposals-on-proposals-accept
… render Ammend Button
isaacmg410
force-pushed
the
feature/amendments-proposals-on-proposals-accept-validate-emendation
branch
from
c571504
to
e77b510
Compare
added 2 commits
November 15, 2018 17:41
isaacmg410
force-pushed
the
feature/amendments-proposals-on-proposals-accept
branch
from
cf1e1e0
to
a7253ea
Compare
aitorlb
pushed a commit
that referenced
this pull request
Aug 8, 2019
tramuntanal
deleted the
feature/amendments-proposals-on-proposals-accept-validate-emendation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)