Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track Updated TOS page in Organization #3

Closed
wants to merge 12 commits into from

Conversation

agustibr
Copy link

@agustibr agustibr commented May 9, 2018

🎩 What? Why?

[decidim-admin] Adds the option to mark as Notable changes in the TOS edit page, The Organization has a new setting tos_version that is updated when the notable_changes checkbox is true

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add/modify seeds
  • Add tests
  • option to mark as notable changes in TOS page
  • migration to add organization setting tos_version
  • traces updates

📷 Screenshots (optional)

  • Last notable change shown in index:
    screenshot from 2018-05-09 12-53-45

  • Edit Page with noticeable changes check_box :
    screenshot from 2018-05-09 12-54-10

  • Version changes in Admin Dashboard:
    screenshot from 2018-05-23 11-26-35

@agustibr agustibr force-pushed the feature/organization_tos_updated_at branch 2 times, most recently from e28665c to bdd8da2 Compare May 15, 2018 11:04
class AddTosUpdatedAtToOrganization < ActiveRecord::Migration[5.1]
def up
add_column :decidim_organizations, :tos_updated_at, :datetime
execute("UPDATE decidim_organizations SET tos_updated_at = NOW()")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be NOW()?

@agustibr agustibr force-pushed the feature/organization_tos_updated_at branch from f2a6318 to cb37d48 Compare May 22, 2018 09:03
@agustibr agustibr mentioned this pull request May 22, 2018
9 tasks
@agustibr agustibr force-pushed the feature/organization_tos_updated_at branch 2 times, most recently from 878169b to ba6b4a1 Compare May 23, 2018 10:10
@agustibr agustibr force-pushed the feature/organization_tos_updated_at branch from ba6b4a1 to 6968d96 Compare May 24, 2018 10:27
@agustibr agustibr closed this May 24, 2018
aitorlb pushed a commit that referenced this pull request Apr 30, 2019
* initial commit selective newsletter

* working on queries recipients

* working on queries

* improve view

* start querying scopes

* send newsletter to users, pending filter participants

* some new improvements on selective newsletter

* initial queries filtering participants

* run rubocop to fix offenses

* remove unnecessary css

* change no_recipients and recipients_query

* adding some translations

* add some translations

* extract participants code to each module

* add class to select option

* fix lint errors

* fix rubocop offenses

* missing locales and fix i18n specs

* add documentation

* add changelog line

* remove unnecessary comma

* working specs

* wip working on specs

* fix offenses

* fix rubocop lambda

* working with specs newsletter

* improve specs query

* fix rubocop on decidim dev

* improve specs

* add newsletters js to manifest and fix newsletter helper

* change translation from any to none

* selective newsletter for space admins (#3)

* selective newsletter for space admins

* refactor space_allows_admin_access? to be more performant

* improve spaces_user_can_admin memoization

* update CHANGELOG entry

* renamed admin_newsletter_action? to apply_newsletter_permissions_for_admin!

* update (space)_user_admins return user objects not ids

* rename Decidim::Admin::NewslettersHelper#space_datum to :space_as_option_for_select

* fix rubocop offense

* A space admin can't send to all users

* add space admin user examples to deliver_newsletter_spec

* remove comments
tramuntanal pushed a commit that referenced this pull request Jan 20, 2021
* revert keys type in smtp_settings from symbol to strings

* switch smtp_settings keys from symbols to strings

* Fix smtp settings specs (#2)

* light cleanup application mailer specs

* add tests in register organization specs

* Revert "Fix smtp settings specs (#2)" (#3)

This reverts commit 9838bec.

* Update organization seeds (#1)

* Update organization seeds

* Fix migration

* Clean tests

* Complete migration by adding down

* Fix smtp settings specs (#4)

* light cleanup application mailer specs

* add tests in register organization specs

* Remove migration and update CHANGELOG

* Remove CHANGELOG entry

Co-authored-by: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com>
Co-authored-by: Armand Fardeau <armandfardeau@users.noreply.github.com>
laurajaime pushed a commit that referenced this pull request May 19, 2022
* allowing only lowercase in the nickname

* nickname test system

* add in locales the "lowercase" precision

* changing routing for timeline

* changing routing for activities

* changing routing for other profile tabs

* migration to change commune nicknames

* linter

* minor changes
increase performance for migration

* Refactor migration for lisibility

* add fix into changelog

* linter

* Update CHANGELOG.md

* add notification when updating nickname

* fix number of notification

* Add notification when updating nickname (#3)

add spec for event
add translation for notification
normalize locales
add logger
refactor
add random numbers to prevent errors

* update message in notification

* update test
linter

* minor changes

* Change requests nickname (#8)

* back to "any case" nickname

* check uniqueness case insensitivity

* change profiles url

* mention, parse case insensitively

* mention, render nicknames case insensitively

* mentions spec

* update migration

* linter

* migration to rake tasks
spec rake task

* linter

* add test notification
fix test nickname

* linter

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Update CHANGELOG.md

* Update account_form.rb

* linter

* remove the if statement
private fonctions

* remove test task

* relaunch tests

* add organization criteria
refactors

* lint

* use nicknamize instead of random numbers

* add the not deleted scope

* update nicknamizable to check for case

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants