User must review TOS when updated #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustibr
force-pushed
the
feature/user_needs_tos_accepted
branch
4 times, most recently
from
edee5b6
to
22e9068
Compare
agustibr
force-pushed
the
feature/user_needs_tos_accepted
branch
from
9bf427d
to
5513119
Compare
tramuntanal
reviewed
May 22, 2018
| @@ -59,6 +59,7 @@ def create_or_find_user | |||
| @user.skip_confirmation! if verified_email | |||
| end | |||
|
|
|||
| @user.tos_accepted_at = @user.organization.tos_updated_at | |||
There was a problem hiding this comment.
If I understand well, @user.tos_accepted_at is not the timestamp when the user accepted the tos but the version of the accepted tos. If this is the case, we should use another name like @user.tos_version or @user.accepted_tos_version.
There was a problem hiding this comment.
Yes you're right, @user.tos_accepted_at is the timestamp of the accepted version of the tos.
Maybe @user.accepted_tos_updated_at is more appropriate, as in another PR the organization will have the tos_updated_at attribute:
add_column :decidim_organizations, :tos_updated_at, :datetime
There was a problem hiding this comment.
I've changed it to accepted_tos_version for User and to tos_version for Organization
agustibr
force-pushed
the
feature/user_needs_tos_accepted
branch
3 times, most recently
from
4f330bc
to
5020a37
Compare
agustibr
force-pushed
the
feature/user_needs_tos_accepted
branch
from
5020a37
to
2e0917b
Compare
tramuntanal
pushed a commit
that referenced
this pull request
Jan 20, 2021
* revert keys type in smtp_settings from symbol to strings * switch smtp_settings keys from symbols to strings * Fix smtp settings specs (#2) * light cleanup application mailer specs * add tests in register organization specs * Revert "Fix smtp settings specs (#2)" (#3) This reverts commit 9838bec. * Update organization seeds (#1) * Update organization seeds * Fix migration * Clean tests * Complete migration by adding down * Fix smtp settings specs (#4) * light cleanup application mailer specs * add tests in register organization specs * Remove migration and update CHANGELOG * Remove CHANGELOG entry Co-authored-by: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com> Co-authored-by: Armand Fardeau <armandfardeau@users.noreply.github.com>
laurajaime
added a commit
that referenced
this pull request
Mar 8, 2021
Backport "Fix duplicated error in datetime_fields" to release/0.22-stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When a user has accepted the TOS (Term Of Service), if it gets updated the user must review and accept again. Or an option to refuse.
📌 Related Issues
📋 Subtasks
CHANGELOGentrytos_accepted_atto userhigh_voltagegem version📷 Screenshots (optional)
Redirected to tos page:
If TOS are accepted:
If the Refuse option is clicked a modal is shown with options:
Accept Invitation screen with TOS checkbox and text:
