Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore standalone editor style #353

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

CGNonofr
Copy link
Contributor

But apply it only on standalone editors

@kaisalmen it's a fix for TypeFox/monaco-languageclient#600 (comment)

Removing it doesn't seem to be an issue on Linux but it is on Window

but apply it only on standalone editors
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@CGNonofr CGNonofr merged commit 051b03f into main Feb 26, 2024
2 checks passed
@CGNonofr CGNonofr deleted the fix-standalone-editor-style branch February 26, 2024 13:37
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kaisalmen
Copy link
Collaborator

Works nicely. Thanks.

@CGNonofr
Copy link
Contributor Author

YEAHHH 🎉

@kaisalmen
Copy link
Collaborator

kaisalmen commented Feb 26, 2024

@CGNonofr unfortunately, the same problem occurs when using the standalone DiffEditor.

@CGNonofr
Copy link
Contributor Author

@CGNonofr unfortunately, the same problem occurs when using the standalone DiffEditor.

Oh... can you please open another issue?

@kaisalmen
Copy link
Collaborator

👍 see: #355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants