If technology, country, or mentor is not found, nothing filters

[brockneedscoffee]

Is your feature request related to a problem? Please describe.
If a user searches for a technology or mentor that does not exist, nothing filters.

Describe the solution you'd like
If nothing is found it should display the same as when you toggle favorites and nothing is found, in a future version it would be nice to have a link to share the site with someone who would be interested or a link to signup to encourage mentors to signup

Describe alternatives you've considered
NA

Additional context
NA

[brockneedscoffee]

I already started coding a fix, once I get access I'd like to be assigned to this

[moshfeu]

Thanks!
I'm not sure I'm following..

[brockneedscoffee]

@moshfeu it only works with the combo. Let's say I don't care about the country and want someone with swift or objective c (those two do not exist yet as tags in the mentor list). I won't get the not found until I add the country piece as well. Attached GIF to show what I mean. You can reproduce by typing objectivec and pressing return. I am using Chrome 73.0.3683.86 on Mojave

[moshfeu]

That's the functionality of autocomplete. It doesn't select anything that's not exists.
How do you think to handle this?

[emmabostian]

Hi, are you saying that if the user tries to search for a skill or country that doesn't exist, and they hit Enter, they should see a message?

[moshfeu]

I'm not sure we have the "enter" functionality in that component.
Also, we may want to wait or implement it as part of #80.

[moshfeu]

Just saw this site which has autocomplete: https://firstcontributions.github.io/

[brockneedscoffee]

@emmawedekind @moshfeu yes I am saying that if they search for a skill or country that does not exist they should see that message. We should pass what they type to the state and compare it to the array like we do with existing items now. the package we use has an example on how to do this. Will have the PR up shortly for you guys to review. Along with the Google Docs API piece @emmawedekind we talked about briefly 😄

[emmabostian]

I like this idea - would you want to open a PR? That way it might be easier to discuss whether it's the right solution!

[moshfeu]

If so, probably it should be done with #80 because we may use a different component.

[emmabostian]

Sure I'm cool with that - should we close this issue and add it as acceptance criteria for #80?

[moshfeu]

Sure I'm cool with that - should we close this issue and add it as acceptance criteria for #80?

Good idea 👍

[emmabostian]

Wonderful!