Implementation of filters

[manpenaloza]

Is your feature request related to a problem? Please describe.
In terms of a ux improvement it might make sense to implement some tag overview that you can also interact with.

Describe the solution you'd like

Acceptance Criteria

• If no skills are found, display the following message: "Whoops! Looks like we don't have a mentor with these filters. Check back soon!"
• If a user types in a language or technology and clicks Enter, it will add it to the list below.
• If a user types in a language or technology and clicks the Add Filter button, it will add it to the list below.
• If a user types in a language or technology the drop down should auto-complete.
• If a user types in a language or technology and clicks an auto-complete label, it should add to the list below.

[moshfeu]

Interesting idea!
@emmawedekind.

[emmabostian]

Love the idea! I'll incorporate it into the re-design and leave the logic up to you if you're still interested :)

[manpenaloza]

sure! Looking forward to it.

[manpenaloza]

fyi: I'll find time for this by the end of next week

[moshfeu]

@emmawedekind do we know how it should look with the new UI? And mobile?

[emmabostian]

Sure I can update the design!

[manpenaloza]

thx for the briefing!

@moshfeu @emmawedekind I'll start implementing based on the current master branch, ok?

[moshfeu]

Wait. We have some "in progress" relates tasks - #136 and #27.
I think we should wait for them. @emmawedekind ?

[manpenaloza]

thx for the info. jap, they're very closely related and developing this issue in parallel will very likely lead to conflicts and bugs. also as it depends on how 'tag is clicked/toggled' state will be handled in those other issues.

so I'll be there if you need me and if this is going to be continued.

[emmabostian]

Let's complete this first, then #136 and #27 can follow!

[manpenaloza]

ok, thx for info. will be busy until the end of this week and will start with this next week. hope that's ok for you.

I'll probably go with what @moshfeu mentioned in #136 regarding the usage of https://react-select.com. More on that when I'll start WIP pr.

[moshfeu]

Thanks!
You can create WIP PR (Just regular PR with WIP in its title so we could track the progress but will know to not merge it yet.)

[manpenaloza]

@moshfeu today got some urgent/important todos that will cover my upcoming dev-weeks. so either i have to postpone this a bit in case it does not hurry (can start in about 3 weeks from now on) or someone else wants to give it a try?

[moshfeu]

Ok! Thanks for letting us know.
If we will find someone (or one of us will take this) I'll let you know.

[emmabostian]

FYI I have added acceptance criteria to this issue!

[emmabostian]

Additionally, we have new designs, so please hold off on development until I've added those in. I should have them updated by tonight!

[brockneedscoffee]

since I started working on this with my open issue I am happy to take this one @moshfeu @emmawedekind @manpenaloza

[moshfeu]

@brockmdavis Sure!
Don't forget to wait for the new design.

[moshfeu]

Just put it here: https://react-select.com/home, https://github.com/jedwatson/react-select

[emmabostian]

@brockmdavis I've added the new design & acceptance criteria in the issue description. I haven't finished the mobile layout yet but will get that as soon as possible.

[emmabostian]

Additionally, with the implementation of #193, we need to make sure that if a user clicks the tag on the profile card that it updates the list below the search bar.

[moshfeu]

Let's wait for it. Ok? I'll review #193 later today.

[brockneedscoffee]

@emmawedekind saw the designs, started on it this morning hope to have some stuff committed shortly.

[moshfeu]

Don't you want to wait for #193?

[emmabostian]

#193 is now merged! :)

[moshfeu]

@brockmdavis Any update? Some PRs merged since then so make to to fetch from the master.
Thanks!

[moshfeu]

Since no response, I'll close this and create a new one for a cleaner view.
Thanks