-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#25 Change querystring while searching for permalinks #249
Feature/#25 Change querystring while searching for permalinks #249
Conversation
Updating from base repository project
…s on search querystring
…ntor into feature/Coding-Coach#25-querystring-on-searching
…autocomplete field
Hi @moshfeu, Please, could you take a look on this Pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like when the user refresh the page, all the users are visible for a moment and then filtered out.
It's because the AutoComplete'scomponentDidMount
is firing after the mentors are already rendered.
It will probably better to filter from the query string in the first filter.
@moshfeu, I will check that in this weekend. |
@analistacarlosh what's the status? We really want to merge it ASAP to include it in the new (and the last) redesign |
Hello @moshfeu, Sorry, I'll take a look today and will give you a feedback tomorrow. |
Ok. Thanks! |
…list on Main component
…onent to be easy to maint the code
Updated master branch
Hi @moshfeu, Please, could you take a look? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me! Let's see what others say 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks!
Screen-record of this feature working: https://www.dropbox.com/s/nznbe1jt2hu630d/25_issue_permalink.mov?dl=0
Please, take a look on this pull request and feel free to send me any questions or feedbacks on my Slack channel.