New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple technologies choices #432
Conversation
Thanks! I'll review it asap. BTW, is that PR done? Because I saw in the code some TODO's. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, I'll put it here:
- No
x
on the tags. - The filter button is not in the right place.
- When add tags "a" and then "b" and click on "b" the URL is remaining the same. When click on "a", "b" removed from the URL and "a" is still there.
- The autocomplete's list in contains tags which already added
Thanks for the review @moshfeu. I'll check it out when I have a chance. Can you clarify on your 4th point though? |
Hi, any progress? |
Hey @moshfeu sorry for the late update. I made some changes here. Let me know what else I can do. Thank you! |
Looks better! Thanks
|
@alexluong Hey! Will you have time to make the fixes that @moshfeu pointed out? Thanks for contribution! |
@alexluong any update? |
Following my chat with Alex, I'll close that PR and we'll assign it to someone else. |
resolve #413
Please do go over the code and see if there's any problem. Let me know and I'll try my best to fix it. Thanks!