New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test #643
Integration test #643
Conversation
@brentmclark can you please review the changes. Thanks |
@junipdewan I like the code, but some of these tests are failing. Have you been able to figure out why yet? I suspect there are some environment-specific differences between local and staging. |
@brentmclark , I have tried to figure out the cause but didn't find any. I have tried by changing |
I'll have a look at my earliest opportunity. |
Quick update; I'm not having a ton of luck hunting this down. My best guess at this point is some form of data variance in the CI environment and the local environment. A decent path forward, in that case, would be to use a fixture to control the API response. This would eliminate any variance between environments. More updates when I can, unless you want to take a crack at adding a fixture @junipdewan? |
@junipdewan what do you think? |
@moshfeu @brentmclark , Sure I will add the fixture to control the API response and update the PR accordingly. |
@junipdewan I added fixtures for the |
@brentmclark Thanks for your update. As I can see #656 is merged. I will work on this current PR and update you. |
@brentmclark I have updated the test cases for mentors spec. Can you please review the changes ? |
This is so great; thank you @junipdewan! If you don't mind touching up those 3 spots I called out that would be most appreciated. I'm ready to approve after that! |
@brentmclark, I have added the changes as per your review. Also added test cases
|
@junipdewan Great work on the changes and the new tests! One of the new tests is failing in CI land, unfortunately. Does anything fail locally? |
@brentmclark No. All test were working fine.So, I have rechecked the test cases again locally but all test cases are passed. |
@brentmclark fixed the failed test cases. |
Looks good to me! @moshfeu does everything look good on your end? |
@brentmclark , @moshfeu. JFYI there is already an opened like/unlike issue. If everything is fine in this PR we can close the issue. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me as well :)
This was a long trip.
Thank you and, of course, @brentmclark ❤️
Great work and impressive dedication @junipdewan. Thanks a ton for your patience as I worked through the core issues with auth in Cypress. I'm so excited to have these tests in place; they will be crucial as the app is enhanced. 🎉 |
Integration Tests for the following
resolve #633