Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test #643

Merged
merged 10 commits into from Dec 2, 2019
Merged

Integration test #643

merged 10 commits into from Dec 2, 2019

Conversation

junip
Copy link
Contributor

@junip junip commented Sep 17, 2019

Integration Tests for the following

  • User can click on mentors channel.
  • Verification of country/technology filter

resolve #633

@junip
Copy link
Contributor Author

junip commented Sep 17, 2019

@brentmclark can you please review the changes. Thanks

@brentmclark
Copy link
Collaborator

@junipdewan I like the code, but some of these tests are failing. Have you been able to figure out why yet? I suspect there are some environment-specific differences between local and staging.

@junip
Copy link
Contributor Author

junip commented Sep 18, 2019

@brentmclark , I have tried to figure out the cause but didn't find any. I have tried by changing env file and pointing API ENDPOINT from staging to production it's working fine.

@brentmclark
Copy link
Collaborator

I'll have a look at my earliest opportunity.

@brentmclark
Copy link
Collaborator

brentmclark commented Sep 24, 2019

Quick update; I'm not having a ton of luck hunting this down. My best guess at this point is some form of data variance in the CI environment and the local environment. A decent path forward, in that case, would be to use a fixture to control the API response. This would eliminate any variance between environments.

More updates when I can, unless you want to take a crack at adding a fixture @junipdewan?

@moshfeu
Copy link
Member

moshfeu commented Sep 29, 2019

@junipdewan what do you think?

@junip
Copy link
Contributor Author

junip commented Oct 3, 2019

@moshfeu @brentmclark , Sure I will add the fixture to control the API response and update the PR accordingly.

@brentmclark
Copy link
Collaborator

@junipdewan I added fixtures for the /mentors endpoint in #656; you may want to wait for that to be merged before moving forward here. It includes a fix for the huge gotcha that cypress does not have native support for window.fetch 🙃

@junip
Copy link
Contributor Author

junip commented Oct 24, 2019

@brentmclark Thanks for your update. As I can see #656 is merged. I will work on this current PR and update you.

@junip
Copy link
Contributor Author

junip commented Nov 24, 2019

@brentmclark I have updated the test cases for mentors spec. Can you please review the changes ?

cypress/integration/mentors.js Outdated Show resolved Hide resolved
cypress/fixtures/users/credentials.json Outdated Show resolved Hide resolved
cypress.json Outdated Show resolved Hide resolved
@brentmclark
Copy link
Collaborator

This is so great; thank you @junipdewan! If you don't mind touching up those 3 spots I called out that would be most appreciated. I'm ready to approve after that!

@junip
Copy link
Contributor Author

junip commented Nov 25, 2019

@brentmclark, I have added the changes as per your review. Also added test cases

  • Like / Unlike the Mentor

@brentmclark
Copy link
Collaborator

@junipdewan Great work on the changes and the new tests! One of the new tests is failing in CI land, unfortunately. Does anything fail locally?

@junip
Copy link
Contributor Author

junip commented Dec 2, 2019

@brentmclark No. All test were working fine.So, I have rechecked the test cases again locally but all test cases are passed.

@junip
Copy link
Contributor Author

junip commented Dec 2, 2019

@brentmclark fixed the failed test cases.

@brentmclark
Copy link
Collaborator

Looks good to me! @moshfeu does everything look good on your end?

@junip
Copy link
Contributor Author

junip commented Dec 2, 2019

@brentmclark , @moshfeu. JFYI there is already an opened like/unlike issue. If everything is fine in this PR we can close the issue. Thanks

Copy link
Member

@moshfeu moshfeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me as well :)
This was a long trip.
Thank you and, of course, @brentmclark ❤️

@moshfeu moshfeu merged commit e30fbdc into Coding-Coach:master Dec 2, 2019
@brentmclark
Copy link
Collaborator

Great work and impressive dedication @junipdewan. Thanks a ton for your patience as I worked through the core issues with auth in Cypress. I'm so excited to have these tests in place; they will be crucial as the app is enhanced.

🎉

@brentmclark brentmclark modified the milestone: mentors-staging Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Like/Unlike flows
3 participants