Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive process for add mentor #65

Merged
merged 24 commits into from
Mar 18, 2019

Conversation

07Gond
Copy link
Member

@07Gond 07Gond commented Mar 13, 2019

This closes #43

You can test the job with: yarn add-user script.

image

image

image

@moshfeu
Copy link
Member

moshfeu commented Mar 13, 2019

Looks good so far 👍
I have some questions. We will talk about it when you will finish.

@07Gond 07Gond marked this pull request as ready for review March 13, 2019 07:44
@07Gond
Copy link
Member Author

07Gond commented Mar 13, 2019

@moshfeu Just updated.
I think that can be improved on visual styles but I don't know.
This is my proposal. 😄

@moshfeu
Copy link
Member

moshfeu commented Mar 13, 2019

Thanks! I will review it soon.

scripts/create-user.js Outdated Show resolved Hide resolved
scripts/create-user.js Outdated Show resolved Hide resolved
scripts/create-user.js Outdated Show resolved Hide resolved
@moshfeu
Copy link
Member

moshfeu commented Mar 13, 2019

Great job!

I also thought about solving another problem regarding to the process.
Sometimes people are adding synonyms tags and countries.
Just throw an idea, how about convert the country and the tags to also options. And add an option (at the top) for "I can't find my country / tag". In he will choose this, another question will allow you to add his own.

What do you think?

Copy link
Member

@crysfel crysfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good!

scripts/create-user.js Outdated Show resolved Hide resolved
@moshfeu moshfeu added the wip Work in progress label Mar 14, 2019
@moshfeu moshfeu added this to In progress in 42 via automation Mar 14, 2019
@emmabostian
Copy link

This is so great thank you!

@emmabostian emmabostian self-requested a review March 14, 2019 05:58
Co-Authored-By: 07Gond <meta.author@gersonnino.me>
@07Gond
Copy link
Member Author

07Gond commented Mar 14, 2019

Hi!
Thanks for the comments! I'm going to do some of those changes.

@moshfeu about the country or tags fields, Today I'm going to do a PoC with an autocomplete or a select list.

@moshfeu
Copy link
Member

moshfeu commented Mar 14, 2019

@07Gond

Great! I think we can go out without the autocomplete because even now, the feature is bring a lot of value. We can add the autocomplete functionality in "phase 2".

WDYT?

@07Gond
Copy link
Member Author

07Gond commented Mar 14, 2019

@moshfeu Ok, I think it's a good option.
Branch just updated with the other fixes.

scripts/add-mentor.js Outdated Show resolved Hide resolved
@moshfeu
Copy link
Member

moshfeu commented Mar 17, 2019

You can also discard your changes in lists.json and mentors.json to avoid conflicts.

@07Gond
Copy link
Member Author

07Gond commented Mar 17, 2019

Just updated the branch with some fixes.

Copy link
Member

@moshfeu moshfeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You did an awesome job here!

@moshfeu moshfeu merged commit 09331cd into Coding-Coach:master Mar 18, 2019
42 automation moved this from In progress to Done Mar 18, 2019
@07Gond 07Gond deleted the add-mentor-cli branch March 18, 2019 13:58
@crisecheverria
Copy link
Contributor

crisecheverria commented Mar 19, 2019

Is possible to Update mentor information using the CLI?
Probably using his/her email account as Id in order to search and then Update the fields.

@moshfeu
Copy link
Member

moshfeu commented Mar 19, 2019

Great idea!
Can you create an issue and refer to this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress
Projects
No open projects
42
  
Done
Development

Successfully merging this pull request may close these issues.

Create an interactive process to add mentor
5 participants