Fixes bug #23 where line number view would overlay the text view #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might break behaviour on very old macOS systems but we have no way to test it. |
jpeinelt
approved these changes
Jan 26, 2020
| @@ -141,7 +143,7 @@ - (IBAction) search: (id) sender { | |||
| if (foundRange.location != NSNotFound) { | |||
| NSRect boundingRect = [[self.textView layoutManager] boundingRectForGlyphRange:foundRange inTextContainer:[self.textView textContainer]]; | |||
| NSPoint scrollPoint = NSMakePoint(0, boundingRect.origin.y); | |||
| [self scollToPoint:scrollPoint]; | |||
| [self scrollToPoint:scrollPoint]; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem is, that Apple seems to have changed how rulers affect the scroll position.
Our line numbers are a ruler in the scroll view. In the past, NSScrollView would automatically inset the content so the ruler does not overlap the content. This has changed but it is unclear when.
Anyway, I did the following: