Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hex gist ids are not supported by the short-code #65

Closed
skaliak opened this issue Mar 20, 2015 · 0 comments
Closed

hex gist ids are not supported by the short-code #65

skaliak opened this issue Mar 20, 2015 · 0 comments

Comments

@skaliak
Copy link
Contributor

skaliak commented Mar 20, 2015

At some point in 2014, GitHub switched from using base-10 numbers for its ids to using hex. filter_gist() in templatetags/short_codes.py expects only digits in the id number, so gists with hex ids are not rendered.

I fixed this in my fork, and I'll be submitting a pull request shortly.
skaliak added a commit to skaliak/codrspace that referenced this issue Mar 20, 2015
@skaliak
fix issue Codrspace#65
4f4f4e3
durden added a commit that referenced this issue Mar 25, 2015
@durden
Merge pull request #66 from skaliak/fix_gist_hex_ids
ec87c20 
fix issue #65
@skaliak skaliak closed this as completed Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skaliak