-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use uv for all pip installs #1090
Merged
lgray
merged 4 commits into
CoffeaTeam:master
from
matthewfeickert:ci/use-uv-for-pip-installs
May 8, 2024
Merged
ci: Use uv for all pip installs #1090
lgray
merged 4 commits into
CoffeaTeam:master
from
matthewfeickert:ci/use-uv-for-pip-installs
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matthewfeickert
commented
May 7, 2024
- Use 'uv pip' for all calls to 'pip install' and 'pip uninstall' in CI workflows.
- c.f. https://github.com/astral-sh/uv/
- Fall back to 'python -m pip' for issue with alternative package index.
- c.f. Installation of torch from pytorch CPU index fails with 'no wheels are available with a matching Python ABI' astral-sh/uv#3437
- Use '--upgrade' as '--upgrade' uses '--resolution highest' by default, which is similar to the 'eager' upgrade strategy in pip.
* Use 'uv pip' for all calls to 'pip install' and 'pip uninstall' in CI workflows. - c.f. https://github.com/astral-sh/uv/ * Fall back to 'python -m pip' for issue with alternative package index. * Use '--upgrade' as '--upgrade' uses '--resolution highest' by default, which is similar to the 'eager' upgrade strategy in pip.
matthewfeickert
commented
May 7, 2024
@nsmith- @lgray This is ready for review (assuming all the CI passes).
These would be faster still if not for astral-sh/uv#3437 requiring a switch to |
Seems this
is a generic failure at the moment given it is also happening in #1087. |
This is being blocked by #1080 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.