[V3] local blacklist ignores roles

[Lunatrius]

Command bugs

Command name

localblacklist

What cog is this command from?

core

What were you expecting to happen?

Adding a role to the local blacklist would/should disallow the person to use commands.

What actually happened?

The user with the blacklisted role could sue the command without issues.

How can we reproduce this issue?

1. Blacklist a role
2. Assign the role to someone and let them use any command

Code

Support for blacklisting roles was added here:

Red-DiscordBot/redbot/core/core_commands.py

Lines 1492 to 1498 in 2784730

	try:
	obj = await commands.MemberConverter().convert(ctx, user_or_role)
	except commands.BadArgument:
	obj = await commands.RoleConverter().convert(ctx, user_or_role)
	user = False
	else:
	user = True

But it looks like it was missed during the actual check:

Red-DiscordBot/redbot/core/global_checks.py

Lines 29 to 34 in 2784730

	_ids = [r.id for r in ctx.author.roles if not r.is_default]
	_ids.append(ctx.author.id)
	if local_whitelist:
	return any(i in local_whitelist for i in _ids)
	return not any(i in local_blacklist for i in _ids)

[Tobotimus]

Resolved by #2134.