Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3] Fix role check in local blacklist/whitelist #2134

Merged
merged 1 commit into from
Sep 17, 2018
Merged

[V3] Fix role check in local blacklist/whitelist #2134

merged 1 commit into from
Sep 17, 2018

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Sep 15, 2018 •
edited

fixes #2133 ,

discord.Role.is_default is a method, not a property.

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

[V3] Fix role check in local blacklist/whitelist
f910d0b 
fixes #2133 , 

`discord.Role.is_default` is a method, not a property.
@Kowlin Kowlin added V3 labels Sep 15, 2018
Tobotimus
Tobotimus approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@Tobotimus Tobotimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😃

@Tobotimus Tobotimus merged commit 113b97b into Cog-Creators:V3/develop Sep 17, 2018
@Tobotimus Tobotimus mentioned this pull request Sep 17, 2018
Closed
@mikeshardmind mikeshardmind deleted the patch-16 branch December 26, 2019 17:01
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobotimus Tobotimus Tobotimus approved these changes

@tekulvw tekulvw Awaiting requested review from tekulvw

Assignees
No one assigned
Labels
Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[V3] local blacklist ignores roles
4 participants
@mikeshardmind @Tobotimus @Jackenmen @Kowlin