Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Downloader] Cogs don't get unloaded after uninstalling. #2216

Closed
Kowlin opened this issue Oct 9, 2018 · 1 comment
Closed

[Downloader] Cogs don't get unloaded after uninstalling. #2216

Kowlin opened this issue Oct 9, 2018 · 1 comment
Labels
Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Milestone
3.0.0rc2

Comments

@Kowlin
Copy link
Member

Kowlin commented Oct 9, 2018

Other bugs

What were you trying to do?

When uninstalling a cog from downloader the cog does not get unloaded.

What were you expecting to happen?

The cog being deleted & unloaded.

What actually happened?

The cog only got deleted, The cog stayed active and in memory.

How can we reproduce this issue?

cog uninstall <3rd party cog>
Check that the cog is still loaded in memory
cogs
@Kowlin Kowlin added Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. V3 labels Oct 9, 2018
Tobotimus added a commit to Tobotimus/Red-DiscordBot that referenced this issue Oct 15, 2018
@Tobotimus
[Downloader] Unload extensions on uninstall
3c78cd6 
Resolves Cog-Creators#2216.

Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
@Tobotimus Tobotimus mentioned this issue Oct 15, 2018
Merged
@Tobotimus Tobotimus added the Status: In Progress There's a PR open to deal with this, or an org member is working on this internally label Oct 15, 2018
@Tobotimus Tobotimus added this to the RC 2 milestone Oct 15, 2018
Tobotimus added a commit that referenced this issue Oct 15, 2018
@Tobotimus
[Downloader] Unload extensions on uninstall (#2243)
aff62a8 
Resolves #2216.

Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
@Tobotimus
Copy link
Member

Resolved by #2243.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: In Progress There's a PR open to deal with this, or an org member is working on this internally Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.0.0rc2
Development

No branches or pull requests
2 participants
@Tobotimus @Kowlin