Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Downloader] Unload extensions on uninstall #2243

Merged
merged 3 commits into from Oct 15, 2018
Merged

[Downloader] Unload extensions on uninstall #2243

merged 3 commits into from Oct 15, 2018

Conversation

Tobotimus
Copy link
Member

Resolves #2216.

@Tobotimus
[Downloader] Unload extensions on uninstall
3c78cd6 
Resolves Cog-Creators#2216.

Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
@Tobotimus Tobotimus added this to the RC 2 milestone Oct 15, 2018
@Tobotimus
Should probably unload *before* deleting
f9730c5 
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
@Tobotimus
Don't await unload_extension
9aeb0e4 
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
mikeshardmind
mikeshardmind approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Tobotimus Tobotimus merged commit aff62a8 into Cog-Creators:V3/release/3.0.0 Oct 15, 2018
@Tobotimus Tobotimus deleted the V3/bugfix/2216 branch October 15, 2018 22:19
@Tobotimus Tobotimus mentioned this pull request Oct 15, 2018
Closed
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshardmind mikeshardmind mikeshardmind approved these changes

@tekulvw tekulvw Awaiting requested review from tekulvw

Assignees

@mikeshardmind mikeshardmind

Labels
Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.0.0rc2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tobotimus @mikeshardmind @Jackenmen