fix uptime for uptime of less than a second #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flame442
requested changes
Sep 27, 2019
| @@ -326,9 +326,10 @@ class Core(commands.Cog, CoreLogic): | |||
| """Shows Red's uptime""" | |||
| since = ctx.bot.uptime.strftime("%Y-%m-%d %H:%M:%S") | |||
There was a problem hiding this comment.
No, this one was left available as a property which only errors if you try to assign to it.
Cog-CreatorsBot
requested changes
Sep 27, 2019
Flame442
added
the
QA: Changes Requested
Flame442
approved these changes
Sep 28, 2019
Cog-CreatorsBot
approved these changes
Sep 28, 2019
Flame442
added
QA: Passed
Jackenmen
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
Yes, I'm aware this is an edge case.