Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trivia] Commands for managing custom trivia lists #3420

Merged
merged 48 commits into from
Mar 21, 2020
Merged

[Trivia] Commands for managing custom trivia lists #3420

merged 48 commits into from
Mar 21, 2020

Conversation

Stonedestroyer
Copy link
Contributor

@Stonedestroyer Stonedestroyer commented Jan 20, 2020 •
edited
Loading

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Trivia upload command.

This is a draft PR so I can take ideas or if I am going in the wrong direction.

Resolves #3307.

  • Upload command
  • Delete command
  • Listing

@Stonedestroyer
Copy link
Contributor Author

How do we want to support duplicate lists?

I am thinking if a duplicate list is uploaded to either ask to overwrite or skip?

And also if a list has the same name as a baselist warn user and gracefully error?

Does these two ideas sond good.

@Drapersniper
Copy link
Contributor

I would personally say if a playlist with the same name we prompt the user to override or skip. or simply silently fail and at the end of the command give a report to the user with failed list and reason it failed.

@Stonedestroyer
Copy link
Contributor Author

Stonedestroyer commented Jan 20, 2020 •
edited
Loading

  • I am looking into adding maybe if you don't supply a file to ask you to add a file into that message or cancel but not sure. This should be done and work fairly well.

Do we need a delete command?

@Stonedestroyer
Copy link
Contributor Author

Stonedestroyer commented Jan 20, 2020 •
edited
Loading

Part 2 will include deletion and also a way to see what is a custom list.
Part 3 which is later will include interactive generator. #3422

@Stonedestroyer Stonedestroyer marked this pull request as ready for review January 20, 2020 11:32
@Stonedestroyer Stonedestroyer changed the title Trivia upload Trivia upload - Part 1 Jan 20, 2020
@Stonedestroyer Stonedestroyer changed the title Trivia upload - Part 1 Trivia custom files - Part 1 Jan 20, 2020
@Stonedestroyer Stonedestroyer changed the title Trivia custom files - Part 1 Trivia custom trivia lists - Upload - Part 1 Jan 20, 2020
@Stonedestroyer Stonedestroyer mentioned this pull request Jan 20, 2020
Closed
3 tasks
@Drapersniper Drapersniper added Category: Cogs - Trivia - Lists Changing or adding trivia lists. Type: Feature New feature or request. labels Jan 20, 2020
@Jackenmen Jackenmen removed the Category: Cogs - Trivia - Lists Changing or adding trivia lists. label Jan 20, 2020
@Stonedestroyer Stonedestroyer changed the title Trivia custom trivia lists - Upload - Part 1 Trivia - Custom trivia files Jan 20, 2020
@Stonedestroyer
Copy link
Contributor Author

This is WIP.

@Stonedestroyer Stonedestroyer mentioned this pull request Jan 20, 2020
Open
6 tasks
@Stonedestroyer
Copy link
Contributor Author

Stonedestroyer commented Jan 20, 2020 •
edited
Loading

This is pretty much done and ready to go for review.

@Jackenmen Jackenmen self-assigned this Mar 14, 2020
@Jackenmen Jackenmen added this to the 3.3.3 milestone Mar 17, 2020
Jackenmen
Jackenmen requested changes Mar 17, 2020
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, a good PR, there are few things that need changing but nothing major.

redbot/cogs/trivia/trivia.py Outdated Show resolved Hide resolved
redbot/cogs/trivia/trivia.py Outdated Show resolved Hide resolved
redbot/cogs/trivia/trivia.py Outdated Show resolved Hide resolved
redbot/cogs/trivia/trivia.py Outdated Show resolved Hide resolved
redbot/cogs/trivia/trivia.py Outdated Show resolved Hide resolved
redbot/cogs/trivia/trivia.py Outdated Show resolved Hide resolved
redbot/cogs/trivia/trivia.py Outdated Show resolved Hide resolved
redbot/cogs/trivia/trivia.py Outdated Show resolved Hide resolved
redbot/cogs/trivia/trivia.py Outdated Show resolved Hide resolved
redbot/cogs/trivia/trivia.py Outdated Show resolved Hide resolved
Jackenmen
Jackenmen requested changes Mar 21, 2020
View reviewed changes
redbot/cogs/trivia/trivia.py Outdated Show resolved Hide resolved
redbot/cogs/trivia/trivia.py Show resolved Hide resolved
Jackenmen
Jackenmen approved these changes Mar 21, 2020
View reviewed changes
Copy link
Member

@Jackenmen Jackenmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@Jackenmen Jackenmen added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Mar 21, 2020
@Jackenmen Jackenmen changed the title Trivia - Custom trivia files [Trivia] Commands for managing custom trivia lists Mar 21, 2020
@Jackenmen Jackenmen merged commit 15e3437 into Cog-Creators:V3/develop Mar 21, 2020
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshardmind mikeshardmind mikeshardmind left review comments

@Jackenmen Jackenmen Jackenmen approved these changes

@Tobotimus Tobotimus Awaiting requested review from Tobotimus

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

@palmtree5 palmtree5 Awaiting requested review from palmtree5

Assignees

@Jackenmen Jackenmen

Labels
Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Feature New feature or request.
Projects
None yet
Milestone
3.3.3
Development

Successfully merging this pull request may close these issues.

Trivia upload command
4 participants
@Stonedestroyer @Drapersniper @Jackenmen @mikeshardmind