Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streams] Attempt to fix unclear error in youtubestream #4148

Merged
merged 1 commit into from
Aug 5, 2020
Merged

[Streams] Attempt to fix unclear error in youtubestream #4148

merged 1 commit into from
Aug 5, 2020

Conversation

flaree
Copy link
Member

@flaree flaree commented Aug 2, 2020 •
edited
Loading

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

raise StreamNotFound error if totalresults is less than 1.

closes #4147

image of testing

@Drapersniper Drapersniper self-assigned this Aug 2, 2020
Drapersniper
Drapersniper approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@Drapersniper Drapersniper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish youtube responses weren't such a mess ... but LGTM and it fixed the issue.

@Drapersniper Drapersniper added the QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). label Aug 5, 2020
@Jackenmen Jackenmen added Category: Cogs - Streams This is related to the Streams cog. Type: Fix labels Aug 5, 2020
@Jackenmen Jackenmen added this to the 3.4.0 milestone Aug 5, 2020
@Drapersniper Drapersniper merged commit 0cc0470 into Cog-Creators:V3/develop Aug 5, 2020
@Cog-CreatorsBot Cog-CreatorsBot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label Aug 5, 2020
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels Aug 7, 2020
Jackenmen pushed a commit that referenced this pull request Aug 17, 2020
@flaree @Jackenmen
[Streams] Attempt to fix unclear error in youtubestream (#4148)
b8e56f3
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drapersniper Drapersniper Drapersniper approved these changes

@palmtree5 palmtree5 Awaiting requested review from palmtree5 palmtree5 is a code owner

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

Assignees

@Drapersniper Drapersniper

Labels
Category: Cogs - Streams This is related to the Streams cog. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. QA: Passed Used by few QA members. Has been approved by the assigned QA member(s). Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

[Streams] youtubestream returns APIError for invalid channel names/ID
4 participants
@flaree @Drapersniper @Jackenmen @Cog-CreatorsBot