Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3 Launcher] cli_flags when no instance #1497

Merged
merged 2 commits into from
Apr 15, 2018
Merged

[V3 Launcher] cli_flags when no instance #1497

merged 2 commits into from
Apr 15, 2018

Conversation

bobloy
Copy link
Contributor

@bobloy bobloy commented Apr 4, 2018

Don't get cli flags unless there is an instance to get

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Don't ask for cli flags when there is no instance
image

Don't get cli flags unless there is an instance to get
@bobloy bobloy requested a review from Twentysix26 as a code owner April 4, 2018 14:37
@Kowlin Kowlin requested a review from palmtree5 April 4, 2018 17:49
@bobloy bobloy changed the title cli_flags when no instance [V3 Launcher] cli_flags when no instance Apr 5, 2018
@palmtree5 palmtree5 added the V3 label Apr 11, 2018
@palmtree5 palmtree5 merged commit 9f7bf8d into Cog-Creators:V3/develop Apr 15, 2018
@bobloy bobloy deleted the cli_flags branch April 16, 2018 00:08
Tobotimus pushed a commit that referenced this pull request Sep 23, 2018
Seems to have been fixed in #1497 but accidentally reverted at a later date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants