Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V3 Launcher] cli_flags when no instance (2) #2142

Merged
merged 1 commit into from
Sep 23, 2018
Merged

[V3 Launcher] cli_flags when no instance (2) #2142

merged 1 commit into from
Sep 23, 2018

Conversation

bobloy
Copy link
Contributor

@bobloy bobloy commented Sep 21, 2018 •
edited

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

image

Same fix as #1497 , unsure why it was reverted.
Don't ask for cli_flags if no instance is found.

@Tobotimus Tobotimus added V3 QA: Bypassed QA is unnecessary. labels Sep 23, 2018
@Tobotimus Tobotimus merged commit fc4703e into Cog-Creators:V3/develop Sep 23, 2018
@bobloy bobloy deleted the V3/cli_flags branch October 2, 2018 12:05
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobotimus Tobotimus Tobotimus approved these changes

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

Assignees
No one assigned
Labels
QA: Bypassed QA is unnecessary. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobloy @Tobotimus @Jackenmen