Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added voice kicking. #2639

Merged
merged 5 commits into from May 3, 2019
Merged

Conversation

Kowlin
Copy link
Member

@Kowlin Kowlin commented May 2, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Adds the newly supported voice channel kicking into Red.

@Kowlin Kowlin added Type: Enhancement Something meant to enhance existing Red features. QA: Needed labels May 2, 2019
@Kowlin Kowlin requested a review from mikeshardmind May 2, 2019 19:43
@Kowlin Kowlin requested a review from palmtree5 as a code owner May 2, 2019 19:43
@mikeshardmind mikeshardmind self-requested a review May 2, 2019 21:21
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you also need to run this against black again for the style check

@@ -19,6 +19,7 @@ def __init__(self, *_args):
self.cache: dict
self.ban_queue: List[Tuple[int, int]]
self.unban_queue: List[Tuple[int, int]]
self._voice_perm_check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should defined as an abstractmethod (see below)

@mikeshardmind mikeshardmind merged commit 9414de2 into Cog-Creators:V3/develop May 3, 2019
@Jackenmen Jackenmen added this to the 3.1.0 milestone Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants