Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added voice kicking. #2639

Merged
merged 5 commits into from May 3, 2019

Conversation

@Kowlin
Copy link
Member

commented May 2, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Adds the newly supported voice channel kicking into Red.

@Kowlin Kowlin requested a review from mikeshardmind May 2, 2019

@Kowlin Kowlin requested a review from palmtree5 as a code owner May 2, 2019

@mikeshardmind mikeshardmind self-requested a review May 2, 2019

@mikeshardmind
Copy link
Member

left a comment

And you also need to run this against black again for the style check

@@ -19,6 +19,7 @@ def __init__(self, *_args):
self.cache: dict
self.ban_queue: List[Tuple[int, int]]
self.unban_queue: List[Tuple[int, int]]
self._voice_perm_check

This comment has been minimized.

Copy link
@mikeshardmind

mikeshardmind May 2, 2019

Member

This should defined as an abstractmethod (see below)

mikeshardmind and others added some commits May 2, 2019

@mikeshardmind mikeshardmind merged commit 9414de2 into Cog-Creators:V3/develop May 3, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.