Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] Change database backend #3193

Closed
wants to merge 25 commits into from
Closed

[Audio] Change database backend #3193

wants to merge 25 commits into from

Conversation

Drapersniper
Copy link
Contributor

@Drapersniper Drapersniper commented Dec 17, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Removed trhe Database dependency and change it over to apsw, + update SQL statements and make them a little bit better

Drapersniper and others added 4 commits Dec 16, 2019
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
@Drapersniper Drapersniper requested a review from Twentysix26 as a code owner Dec 17, 2019
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

This isn't a full review, just some things which I noticed at a relatively brief glance.

redbot/cogs/audio/apis.py Outdated Show resolved Hide resolved
redbot/cogs/audio/apis.py Outdated Show resolved Hide resolved
redbot/cogs/audio/apis.py Outdated Show resolved Hide resolved
Drapersniper and others added 7 commits Dec 18, 2019
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
redbot/cogs/audio/apis.py Outdated Show resolved Hide resolved
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Dec 20, 2019
Drapersniper and others added 4 commits Dec 20, 2019
ToDo.. Nuke existing playlist - check version and set version

Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
@mikeshardmind mikeshardmind self-assigned this Dec 20, 2019
@Drapersniper
Copy link
Contributor Author

@Drapersniper Drapersniper commented Dec 20, 2019

Do we want the cache tables AND Playlist table to be in the same Database?
This PR uses "cache.db" but #3195 uses "Audio.db"... I'm all for making the cache tables into "Audio.db". WDYT @mikeshardmind. If the answer is yes should i reuse the connection/cursor or should i keep them separate

@mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Dec 20, 2019

Same DB, singular connection. Multiple cursors is fine.

Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
@Drapersniper
Copy link
Contributor Author

@Drapersniper Drapersniper commented Dec 21, 2019

Do not merge this one ... Merge #3205

@Flame442 Flame442 added the Type: Enhancement label Dec 22, 2019
@Drapersniper
Copy link
Contributor Author

@Drapersniper Drapersniper commented Dec 22, 2019

Will setup a CPR for all of this so itsd easier to follow ... less likely to fuck up)

@Drapersniper Drapersniper deleted the apsw branch Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants