Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Prevent users from locking out themselves or guild owner with localblacklist #3221

Merged
merged 10 commits into from
Dec 27, 2019
Merged

[Core] Prevent users from locking out themselves or guild owner with localblacklist #3221

merged 10 commits into from
Dec 27, 2019

Conversation

Jackenmen
Copy link
Member

@Jackenmen Jackenmen commented Dec 25, 2019 •
edited
Loading

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes #3207
Partial solution for #3222 (guild owners will be able to run commands even when they're not on whitelist but people who aren't guild owners can still lock themselves out if they don't use this [p]localwhitelist add command carefully)

@Jackenmen
Copy link
Member Author

ehehe, just figured that you can also lock yourself out with localwhitelist 😄

@Jackenmen Jackenmen changed the title [Core] Prevent users from locking themselves out with localblacklist [Core] Prevent users from locking out themselves or guild owner with localblacklist Dec 26, 2019
mikeshardmind
mikeshardmind suggested changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also warrants minor changes to the actual logic used in the bot for this to retroactively prevent guild owners from being impacted by either this or local whitelist as well, up to you if you think that should be a separate PR or not.

redbot/core/core_commands.py Outdated Show resolved Hide resolved
Jackenmen and others added 2 commits December 27, 2019 23:11
@Jackenmen @mikeshardmind
Update redbot/core/core_commands.py
8907343 
Co-Authored-By: Michael H <michael@michaelhall.tech>
@Jackenmen
Update bot.py
b3a9c50
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Dec 27, 2019
mikeshardmind
mikeshardmind previously approved these changes Dec 27, 2019
View reviewed changes
@mikeshardmind mikeshardmind merged commit aabdabf into Cog-Creators:V3/develop Dec 27, 2019
@Jackenmen Jackenmen deleted the patch-6 branch January 4, 2020 07:18
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeshardmind mikeshardmind mikeshardmind approved these changes

@tekulvw tekulvw Awaiting requested review from tekulvw

@Twentysix26 Twentysix26 Awaiting requested review from Twentysix26

Assignees
No one assigned
Labels
Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

[Core] Users can lock out themselves with [p]locablacklist add
3 participants
@Jackenmen @mikeshardmind @Flame442