Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Prevent users from locking out themselves or guild owner with localblacklist #3221

Merged
merged 10 commits into from Dec 27, 2019

Conversation

jack1142
Copy link
Member

@jack1142 jack1142 commented Dec 25, 2019

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

Fixes #3207
Partial solution for #3222 (guild owners will be able to run commands even when they're not on whitelist but people who aren't guild owners can still lock themselves out if they don't use this [p]localwhitelist add command carefully)

@jack1142 jack1142 requested a review from tekulvw as a code owner Dec 25, 2019
@jack1142
Copy link
Member Author

@jack1142 jack1142 commented Dec 25, 2019

ehehe, just figured that you can also lock yourself out with localwhitelist 😄

@jack1142 jack1142 requested a review from Twentysix26 as a code owner Dec 26, 2019
@jack1142 jack1142 changed the title [Core] Prevent users from locking themselves out with localblacklist [Core] Prevent users from locking out themselves or guild owner with localblacklist Dec 26, 2019
Copy link
Contributor

@mikeshardmind mikeshardmind left a comment

Also warrants minor changes to the actual logic used in the bot for this to retroactively prevent guild owners from being impacted by either this or local whitelist as well, up to you if you think that should be a separate PR or not.

redbot/core/core_commands.py Outdated Show resolved Hide resolved
jack1142 and others added 2 commits Dec 27, 2019
Co-Authored-By: Michael H <michael@michaelhall.tech>
@mikeshardmind mikeshardmind added this to the 3.2.0 milestone Dec 27, 2019
mikeshardmind
mikeshardmind previously approved these changes Dec 27, 2019
@mikeshardmind mikeshardmind merged commit aabdabf into Cog-Creators:V3/develop Dec 27, 2019
1 check passed
@jack1142 jack1142 deleted the patch-6 branch Jan 4, 2020
@jack1142 jack1142 added the Type: Bug label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants