Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pip 20.3 (a.k.a. use old dependency resolver) and disallow pip 21 #4644

Closed

Conversation

Jackenmen
Copy link
Member

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

This makes use of -use-deprecated=legacy-resolver for pip 20.3.x to avoid using the new dependency resolver in Downloader until we ensure proper support for how it works. Until then, Red will forbid using pip 21 to avoid problems that may occur because of it.

@Jackenmen Jackenmen added Type: Fix Release Blocker This needs handling prior to the next non-hotfix release. Category: Cogs - Downloader This is related to the Downloader cog. labels Nov 30, 2020
@Jackenmen Jackenmen added this to the 3.4.4 milestone Nov 30, 2020
@Jackenmen Jackenmen removed the Release Blocker This needs handling prior to the next non-hotfix release. label Nov 30, 2020
@Jackenmen
Copy link
Member Author

Turns out it's not really all that important because even with the new resolver, pip still ignores dependencies when --target is used.

@Jackenmen Jackenmen modified the milestones: 3.4.4, 3.4.5 Dec 15, 2020
@Jackenmen Jackenmen modified the milestones: 3.4.6, 3.4.7 Jan 17, 2021
@Jackenmen Jackenmen closed this Jun 25, 2021
@Jackenmen Jackenmen added the Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. label Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Downloader This is related to the Downloader cog. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant