Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streams] Smashcast removal. #5040

Merged
merged 3 commits into from May 15, 2021
Merged

[Streams] Smashcast removal. #5040

merged 3 commits into from May 15, 2021

Conversation

flaree
Copy link
Member

@flaree flaree commented May 13, 2021

Removes smashcast, the service apparently died back in November.

Closes #5039

@flaree flaree requested a review from palmtree5 as a code owner May 13, 2021 10:43
@github-actions github-actions bot added the Category: Cogs - Streams This is related to the Streams cog. label May 13, 2021
@Jackenmen Jackenmen added the Type: Removal This intends to remove some functionality. label May 15, 2021
@Jackenmen Jackenmen added this to the 3.4.11 milestone May 15, 2021
palmtree5
palmtree5 requested changes May 15, 2021
View reviewed changes
Copy link
Member

@palmtree5 palmtree5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changes to the cog guide for the Streams cog

@github-actions github-actions bot added the Category: Docs - Other This is related to documentation that doesn't have its dedicated label. label May 15, 2021
@palmtree5 palmtree5 merged commit 54e5307 into Cog-Creators:V3/develop May 15, 2021
@Cog-CreatorsBot Cog-CreatorsBot added the Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. label May 15, 2021
@flaree flaree deleted the smashcast-removal branch May 15, 2021 16:55
@Jackenmen Jackenmen modified the milestones: 3.4.11, 3.4.10 May 15, 2021
@Jackenmen Jackenmen added Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. and removed Changelog Entry: Pending Changelog entry for this PR hasn't been added by repo maintainers yet. labels May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palmtree5 palmtree5 palmtree5 approved these changes

Assignees
No one assigned
Labels
Category: Cogs - Streams This is related to the Streams cog. Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Changelog Entry: Added Changelog entry for this PR has already been added to changelog PR. Type: Removal This intends to remove some functionality.
Projects
None yet
Milestone
3.4.10
Development

Successfully merging this pull request may close these issues.

Streams | smashcast api appears to be dead
4 participants
@flaree @palmtree5 @Jackenmen @Cog-CreatorsBot