Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf needs zlib #23

Closed
BillWSY opened this issue Nov 16, 2017 · 1 comment
Closed

protobuf needs zlib #23

BillWSY opened this issue Nov 16, 2017 · 1 comment

Comments

@BillWSY
Copy link
Member

BillWSY commented Nov 16, 2017

The ROS official build does not have zlib, so protobuf is compiled with HAVE_ZLIB=0, which disables gzip stream.

We should make this package depend on zlib
@BillWSY
Copy link
Member Author

BillWSY commented Nov 16, 2017

Or we just set HAVE_ZLIB in $PROTOBUF_CPPFLAGS_EXTRA

BillWSY added a commit that referenced this issue Nov 20, 2017
@BillWSY
Depend on zlib (#23) and link protobuf with zlib (#22)
a93e2ea
BillWSY added a commit that referenced this issue Nov 20, 2017
@BillWSY
Depend on zlib (#23) and link protobuf with zlib (#22) (#24)
299b4cc
@BillWSY BillWSY closed this as completed Dec 1, 2017
abishekh added a commit to abishekh/catkin_grpc that referenced this issue Feb 14, 2018
@abishekh
Updating (#1)
5fe9e3a 
* Depend on absolute path of .proto file (CogRob#21)

This should fix CogRob#20. The original concern was for some reason cmake re-generate protos if .proto is not within src. Initial test shows this is not the case, but should do more tests.

* Depend on zlib (CogRob#23) and link protobuf with zlib (CogRob#22) (CogRob#24)

* Updates changelog.

* 0.0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BillWSY