Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed cronet dependencies #47

Merged
merged 1 commit into from
May 12, 2023
Merged

Removed cronet dependencies #47

merged 1 commit into from
May 12, 2023

Conversation

rockenbf
Copy link
Contributor

The cronet libraries are not being build (to the best of my knowledge only used for android) and are therefore a missing dependency.

@mintar
Copy link

mintar commented May 5, 2023

I needed this PR too in order to fix the broken build on Noetic.

@BillWSY , @garaemon : Could you merge this PR and create a new release, please?

@garaemon
Copy link
Collaborator

@mintar
Got it. I'm checking this change in my local environment. I'll get back to you soon.

@garaemon garaemon merged commit 57de51a into CogRob:master May 12, 2023
@garaemon
Copy link
Collaborator

@mintar
I just opened a PR to release a new version.
ros/rosdistro#37219

@garaemon
Copy link
Collaborator

@mintar It's merged. https://mail.google.com/mail/u/0/#inbox/FMfcgzGsmWxzJqvPrFZbzjmjGhwLxFsz
Please wait for the next release of the packages 😄

@mintar
Copy link

mintar commented May 12, 2023

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants