Skip to content

Commit

Permalink
Updating global coverage requirement to 50% and diff-coverage require…
Browse files Browse the repository at this point in the history
…ment to 75%
  • Loading branch information
aarmoa committed Aug 16, 2021
1 parent 936e656 commit 741c763
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .coveragerc
Expand Up @@ -39,7 +39,7 @@ dynamic_context = test_function
branch = true

[report]
fail_under = 42
fail_under = 50
precision = 2
skip_empty = true

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/workflow.yml
Expand Up @@ -103,14 +103,14 @@ jobs:
run: |
source /usr/share/miniconda/etc/profile.d/conda.sh
conda activate hummingbot
coverage run -m nose test.hummingbot
make test
- name: Check and report global coverage
if: steps.program-changes.outputs.cache-hit != 'true' || steps.conda-dependencies.outputs.cache-hit != 'true'
shell: bash
run: |
source /usr/share/miniconda/etc/profile.d/conda.sh
conda activate hummingbot
coverage report
make report_coverage
- name: Validate coverage for the changes
if: github.event_name == 'pull_request' && (steps.program-changes.outputs.cache-hit != 'true' || steps.conda-dependencies.outputs.cache-hit != 'true')
shell: bash
Expand All @@ -120,7 +120,7 @@ jobs:
git fetch --all -q
git checkout -b $GITHUB_SHA
coverage xml
diff-cover --compare-branch=origin/$GITHUB_BASE_REF --fail-under=66 coverage.xml
diff-cover --compare-branch=origin/$GITHUB_BASE_REF --fail-under=75 coverage.xml
# Notify results to discord
- uses: actions/setup-ruby@v1
Expand Down

0 comments on commit 741c763

Please sign in to comment.