feat/ add arbitrum as new ethereum network #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisocana
added
the
foundation
|
Need to fix the unit tests. Otherwise, LGTM. |
|
Oh... this is actually an external contribution. @emersonmacro you should propose this to the Hummingbot Foundation repo instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Adds
arbitrumOneas a new network for theethereumchain and as an option for theuniswap.v3connector. As far as I can tell, Uniswap v2 has not been deployed onto Arbitrum One, so I just added support for the Uniswap v3 deployment.This PR is part of my hackathon project at the ETHPortland hackathon.
Tests performed by the developer:
Added new unit test:
gateway/test/chains/ethereum/uniswap/uniswap.v3.arbitrum.test.ts(adapted from the currentuniswap.v3.test.tsfile)I ran out of time and couldn't get my local hummingbot instance to talk with my local gateway-v2 process, so I wasn't able to actually test the connector in a running hummingbot client. It's quite possible that I'm missing something, so definitely open to feedback on this PR.
Tips for QA testing:
The Arbitrum token list in the PR has been adapted from https://bridge.arbitrum.io/token-list-42161.json (a suggestion from
vic-enon Discord).