Skip to content

Commit

Permalink
perf: Lazy load classes in type resolver
Browse files Browse the repository at this point in the history
  • Loading branch information
Col-E committed Aug 22, 2021
1 parent 994a183 commit 351ab73
Show file tree
Hide file tree
Showing 2 changed files with 59 additions and 2 deletions.
58 changes: 58 additions & 0 deletions src/main/java/me/coley/recaf/parse/source/WorkspaceClassPath.java
@@ -0,0 +1,58 @@
package me.coley.recaf.parse.source;

import javassist.ClassPath;
import me.coley.recaf.util.Log;
import me.coley.recaf.workspace.Workspace;

import java.io.ByteArrayInputStream;
import java.io.InputStream;
import java.net.URL;
import java.net.URLConnection;
import java.net.URLStreamHandler;

/**
* Javassist classpath implementation that pulls classes from a workspace.
*
* @author Matt Coley
*/
public class WorkspaceClassPath implements ClassPath {
private static final RecafStreamHandler dummyUrlHandler = new RecafStreamHandler();
private final Workspace workspace;

/**
* @param workspace
* Workspace to pull classes from.
*/
public WorkspaceClassPath(Workspace workspace) {
this.workspace = workspace;
}

@Override
public InputStream openClassfile(String classname) {
byte[] bytes = workspace.getRawClass(classname);
if (bytes != null)
return new ByteArrayInputStream(bytes);
return null;
}

@Override
public URL find(String classname) {
// Javassist does a URL lookup before allowing any actual reading, so we have to supply some
// dummy value in order to then call "openClassfile"
try {
String internalName = classname.replace('.', '/');
return new URL(null, "recaf:" + internalName, dummyUrlHandler);
} catch (Exception ex) {
Log.error("Failed to create 'recaf' URL scheme", ex);
return null;
}
}

private static class RecafStreamHandler extends URLStreamHandler {
@Override
protected URLConnection openConnection(URL u) {
// No-op
return null;
}
}
}
Expand Up @@ -30,8 +30,7 @@ public class WorkspaceTypeResolver implements TypeSolver {
*/
public WorkspaceTypeResolver(Workspace workspace) {
this.workspace = workspace;
for (String name : workspace.getClassNames())
classPool.insertClassPath(new ByteArrayClassPath(name.replace("/", "."), workspace.getRawClass(name)));
classPool.appendClassPath(new WorkspaceClassPath(workspace));
classPool.appendSystemPath();
}

Expand Down

0 comments on commit 351ab73

Please sign in to comment.