Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please publish wheels for Python 3.10 #29

Closed
gertvdijk opened this issue Feb 4, 2022 · 7 comments · Fixed by #30 or #32
Closed

Please publish wheels for Python 3.10 #29

gertvdijk opened this issue Feb 4, 2022 · 7 comments · Fixed by #30 or #32

Comments

@gertvdijk
Copy link

Using a Python 3.10 venv upgraded from 3.9, pip grabs a source package and requires me to have Go SDK installed on the target system. Could you please also build and publish wheels for 3.10? Thanks!
@ColdHeat
Copy link
Owner

ColdHeat commented Feb 6, 2022

I will get to this but if you were to put up a PR that adds 3.10 to cibuildwheel that would be helpful as well!

@ColdHeat
Copy link
Owner

ColdHeat commented Feb 6, 2022

Actually looking at this, this is probably due to not having a version bump to trigger a new release. Sounds like a good time to update bluemonday as well.

@ColdHeat ColdHeat mentioned this issue Feb 11, 2022
Merged
ColdHeat added a commit that referenced this issue Feb 11, 2022
@ColdHeat
Bump bluemonday to 1.0.18 (#30)
5c3c96a 
* Bump bluemonday to 1.0.18
* Implement rough support for `RequireSandboxOnIFrame` by having an approach to call functions that take typed arguments
    * This doesn't work entirely because currently only a single call to `RequireSandboxOnIFrame` will work but it will suffice until this behavior is actually needed. 
* Build wheels for Python 3.10 (Closes #29)
@ColdHeat
Copy link
Owner

This should be resolved now.

@gertvdijk
Copy link
Author

Hi,

Thanks for picking this up, but this seems incomplete. Wheels are only provided for i686 and aarch64, not for the most common one: x86_64. cp39 has even five architechtures supported.
Screenshot_20220216_031327

Not sure I understand the CI pipeline here and the matrix in order to help out, I'm not familiar with the tooling used here, sorry, there seem many layers of indirections and I am unfamiliar with all of them (GitHub actions, the 'cibuildwheel' project, etc.)

@ColdHeat
Copy link
Owner

Interesting, thanks for noticing I just assumed this would work but I will take a deeper look.

@ColdHeat ColdHeat reopened this Feb 16, 2022
@ColdHeat ColdHeat mentioned this issue Feb 16, 2022
Merged
ColdHeat added a commit that referenced this issue Feb 16, 2022
@ColdHeat
Add musl linux back into the build matrix (#32)
328a899 
* Add musllinux to the build matrix and try to get go running properly under alpine (Closes #31)
* Fix building wheels for Python 3.10 (Closes #29)
@ColdHeat
Copy link
Owner

image

I believe this should be good now.

@gertvdijk
Copy link
Author

It is working, thanks! 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ColdHeat @gertvdijk