Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build wheels for Apple Silicon macs, drop support for Python 3.6 #37

Merged
merged 18 commits into from
May 12, 2023

Conversation

patricksanders
Copy link
Contributor

This PR upgrades cibuildwheel to the latest version to support building macOS arm64 wheels.

The first version of cibuildwheel to support Apple Silicon is 2.10.0, while support for running with Python 3.6 was dropped in v2.9.0. Python 3.6 has been EOL since the end of 2021, so I opted to remove support for 3.6. Hope that's okay.

Fixes #34

@ColdHeat
Copy link
Owner

Thanks for filing this it's a big help! I think dropping 3.6 is fine.

@ColdHeat
Copy link
Owner

Any idea why this is breaking on Windows?

@patricksanders
Copy link
Contributor Author

Dang, I was going to ask if you knew. 😒

I poked around at this a bit yesterday but quickly realized just how weak my Windows hacking is these days. I'll continue looking into it as time permits, but please let me know if you have any ideas.

@ColdHeat
Copy link
Owner

ColdHeat commented May 11, 2023 via email

@ColdHeat
Copy link
Owner

At this point I don't know and this requires some deeper investigation than I can commit to. Someone needs to play around with this in a Windows VM which I don't have the time to setup at the moment.

@ColdHeat
Copy link
Owner

This is failing on master as well. I suspect it is somehow because of the lack of vcpython27 which appears to no longer be installable.

@ColdHeat
Copy link
Owner

Actually I lied, the previous builds generate the same error but still seem to work. You can see at https://github.com/ColdHeat/pybluemonday/actions/runs/4685264396/jobs/8302200836.

Really stumped now.

@patricksanders
Copy link
Contributor Author

I've got two main suspicions right now:

Pretty stumped as well. It might be worth trying to soft link python37 to python to see if that gets us past this.

@ColdHeat
Copy link
Owner

I believe the issue is that cibuildwheel is installing its own Python but then ld is unable to find the location for the python37 library.

@ColdHeat
Copy link
Owner

The issue is somewhere in CIBW but it will take awhile to narrow down and I don't have the interest to dig into it. Somewhere between CIBW 2.3.1 and CIBW 2.12.3 the build gets broken.

I'm just downgrading to 2.3.1 specifically for Windows. This loses Python 3.11 builds on Windows but I am okay with that for now.

@patricksanders If this is okay with you I can merge.

@patricksanders
Copy link
Contributor Author

Yup, that's totally fine with me. Thanks for all the help troubleshooting.

@ColdHeat ColdHeat merged commit d38c55e into ColdHeat:master May 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: subprocess-exited-with-error
2 participants