-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build wheels for Apple Silicon macs, drop support for Python 3.6 #37
Conversation
Thanks for filing this it's a big help! I think dropping 3.6 is fine. |
Any idea why this is breaking on Windows? |
Dang, I was going to ask if you knew. 😒 I poked around at this a bit yesterday but quickly realized just how weak my Windows hacking is these days. I'll continue looking into it as time permits, but please let me know if you have any ideas. |
This reverts commit a69a2ad.
At this point I don't know and this requires some deeper investigation than I can commit to. Someone needs to play around with this in a Windows VM which I don't have the time to setup at the moment. |
This is failing on master as well. I suspect it is somehow because of the lack of vcpython27 which appears to no longer be installable. |
Actually I lied, the previous builds generate the same error but still seem to work. You can see at https://github.com/ColdHeat/pybluemonday/actions/runs/4685264396/jobs/8302200836. Really stumped now. |
I've got two main suspicions right now:
Pretty stumped as well. It might be worth trying to soft link |
I believe the issue is that cibuildwheel is installing its own Python but then ld is unable to find the location for the python37 library. |
The issue is somewhere in CIBW but it will take awhile to narrow down and I don't have the interest to dig into it. Somewhere between CIBW 2.3.1 and CIBW 2.12.3 the build gets broken. I'm just downgrading to 2.3.1 specifically for Windows. This loses Python 3.11 builds on Windows but I am okay with that for now. @patricksanders If this is okay with you I can merge. |
Yup, that's totally fine with me. Thanks for all the help troubleshooting. |
This PR upgrades
cibuildwheel
to the latest version to support building macOS arm64 wheels.The first version of
cibuildwheel
to support Apple Silicon is 2.10.0, while support for running with Python 3.6 was dropped in v2.9.0. Python 3.6 has been EOL since the end of 2021, so I opted to remove support for 3.6. Hope that's okay.Fixes #34