Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Draft v4 #6

Merged
merged 9 commits into from
Feb 16, 2020
Merged

Implement Draft v4 #6

merged 9 commits into from
Feb 16, 2020

Conversation

Colin-b
Copy link
Owner

@Colin-b Colin-b commented Feb 16, 2020

closes #2
closes #3

Changed

  • Update to latest RFC specification (draft v4) meaning:
    • affectedEndpoints is not sent anymore in case status is pass.
    • output is not sent anymore in case status is pass.
    • additional keys can now be provided.

Added

  • healthpy.response_body function to retrieve a dict to return as JSON to the client.
  • healthpy.response_status_code function to retrieve an HTTP status code to return to the client.
  • healthpy.consul_response_status_code function to retrieve an HTTP status code to return to Consul.

Fixed

  • affectedEndpoints is not sent anymore if not provided.

Deprecated

  • Providing non mandatory parameters via positional arguments will be removed in the next major release.

@Colin-b Colin-b added this to the 1.8.0 milestone Feb 16, 2020
@Colin-b Colin-b merged commit 15c6707 into develop Feb 16, 2020
@Colin-b Colin-b deleted the feature/draftv4 branch February 16, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document a sample usage to check health of an HTTP service Handle RFC draft v4 (2019-12-31)
1 participant