-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable document Navigator #6248
Comments
I look to my old notes on this subject (navigator) and I think we have an opportunity here to improve also existing things or make it worse:
Please check gh#6248-navigator-online.odp (pass Still any of this ^ should not be taken as a guide or set of instructions. I'm merely initiating a discussion here. Any feedback is welcome. |
That's a great idea to have only one Navigator icon where the navigation will popup. What I really really like is that the Navigator is not writer only, there will be also the tabs for calc and the slide previews for impress/draw. Maybe we can expand the Navigator for search and other stuff in the future too (as you show links, comments, ... in the mockup). At least for mobile it would be also a great improvement to have an navigator icon instead of an preview's toolbar for example. |
collected what buttons/controls would work in Lool now: WRITER: what not works: I dont know: CALC: IMPRESS: TreeContent works in all 3, but it does not know all the PC capabilities, like right click menu, stepping up/down with keyboard... There are still some glitches with the selection |
[edited] Writer
Calc
Impress
|
I found these glitches/errors: Single user:
Unsuccessful Drag&drop item in Tree, change scrollness (FullUpdate?):
Actual scroll Position changes with sidebar on/off toggle
multi user:
Change on Tree update other user Tree, resulting non needed scolls
Design question:
not sure (maybe not happened):
|
We should probably rename it from "Navigator" to something else. For example "Document Outline" as tooltip (hover) and as Title maybe just "Outline" |
Yup, agree with that one! :) |
Just a note here. In the long run and once the Navigator is placed as shown in #6248 (comment) [1] I still think
1."Please check gh#6248-navigator-online.odp (pass gh#6248-navigator) for a quick mockup of what I have in mind." |
@pedropintosilva sure, "Navigation" seems good as well. :) Note that one of the bigger things is also that in both G and MS cases, the navigation is on the left (we do the same for the outline in Nextcloud Text), so that would be something to look into. |
@jancborchardt agreed, that's what I meant in my previous comment with "For now: It can be to generic specially since Navigator is still not integrated with pages/slides sorter" (s/to/too) |
@pedropintosilva Can you please update this issue to reflect the current state? |
excerpt from #6248 (comment)
Just a quick update:
|
Detailed description and rationale
Expose the functionality (Navigator) already present in the LibreOffice (LO) Core. The Navigator displays the different parts of a document, such as headings, tables, frames, objects, or hyperlinks. To see it in action. Open LO Writer and press F5, this will open Navigator. Quick jump to a location in the document by double-clicking an item listed in the Navigator window or enter the respective page number in the spin button.
Initially and if easier, this could be limited (by priority):
Milestones with estimated time
Code pointers
These might (not) be helpful, in doubt consult with @aszucs3 and @eszkadev :
Disabled switching to navigator: https://cgit.freedesktop.org/libreoffice/core/commit/?id=ca54fde
Code handling uno commands in the core: https://opengrok.libreoffice.org/xref/core/desktop/source/lib/init.cxx?r=aea216e2#4263
Callback commands to send message from core to online: https://opengrok.libreoffice.org/xref/core/include/LibreOfficeKit/LibreOfficeKitEnums.h?r=c4b93412
Navigator panel implementation: https://opengrok.libreoffice.org/xref/core/sw/source/uibase/utlui/navipi.cxx
JSDialogs Treeview widget in Online: https://github.com/CollaboraOnline/online/blob/master/browser/src/control/Control.JSDialogBuilder.js#L1715
Navigator's context menu: https://opengrok.libreoffice.org/xref/core/sw/source/uibase/utlui/content.cxx?r=6a031514#1333
JSDialogs core implementation: https://opengrok.libreoffice.org/xref/core/vcl/jsdialog/jsdialogbuilder.cxx
Current JSDialogs popups generation: https://github.com/CollaboraOnline/online/blob/master/browser/src/control/Control.JSDialog.js#L105
Required skills / knowledge
C++ - LibreOffice core hacking will be needed
JavaScript + CSS - Collabora Online side
WIP
#6237
https://gerrit.libreoffice.org/c/core/+/150906
The text was updated successfully, but these errors were encountered: