Use tokens.equals() instead of tokens[] == #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents additional strings from being allocated. Signed-off-by: Hugo Peixoto <hugo.peixoto@gmail.com> Change-Id: I84b1e5cf4d11bf8512febe068b3097770b63dc5c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that there are still some instances of tokens[1] == "blerp" that could be replaced with tokens.equals(1, "blerp"),
and some instances of tokens[1] == othertokens[2] that could be tokens.equals(1, othertokens, 2).
This change prevents additional strings from being allocated.
First mentioned here: #2697 (comment)
I did
make runand checked that things worked, but I can't tell which part these affect so I'd appreciate a closer look into the change to see if I missed something.Checklist
make checkmake runand manually verified that everything looks okay